threads / patch / 55165

v2doc: fix naming of response-end-pkt

Subject: [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt

## tl;dr

2 messages between Feb 18, 2021 and Feb 18, 2021. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Joey Salazar· Feb 18, 2021, 00:11 UTC · lore

Git Protocol version 2[1] defines 0002 as a Message Packet that indicates the end of a response for stateless connections.

Change the naming of the 0002 Packet to 'Response End' to match the parsing introduced in Wireshark's MR !1922 for consistency. A subsequent MR in Wireshark will address additional mismatches.

[1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922

Signed-off-by: Joey Salazar <jgsal@protonmail.com>
---
 Documentation/technical/protocol-v2.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to Documentation/technical/protocol-v2.txt +2 −3
diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt
index e597b74da39..fc163ca605c 100644
--- a/Documentation/technical/protocol-v2.txt
+++ b/Documentation/technical/protocol-v2.txt
@@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:

   * '0000' Flush Packet (flush-pkt) - indicates the end of a message
   * '0001' Delimiter Packet (delim-pkt) - separates sections of a message
-  * '0002' Message Packet (response-end-pkt) - indicates the end of a response
-    for stateless connections
+  * '0002' Response End Packet (response-end-pkt) - indicates the end of a
+    response for stateless connections

 Initial Client Request
 ----------------------
--
2.29.0.rc2
Denton Liu· Feb 18, 2021, 03:49 UTC · re: Joey Salazar · lore

Re: [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt

On Thu, Feb 18, 2021 at 12:11:22AM +0000, Joey Salazar wrote:
Show 11 quoted lines
> Git Protocol version 2[1] defines 0002 as a Message Packet that indicates
> the end of a response for stateless connections.
> 
> Change the naming of the 0002 Packet to 'Response End' to match the
> parsing introduced in Wireshark's MR !1922 for consistency. A subsequent
> MR in Wireshark will address additional mismatches.
> 
> [1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html
> [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922
> 
> Signed-off-by: Joey Salazar <jgsal@protonmail.com>
Reviewed-by: Denton Liu <liu.denton@gmail.com>
Show 22 quoted lines
> ---
>  Documentation/technical/protocol-v2.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt
> index e597b74da39..fc163ca605c 100644
> --- a/Documentation/technical/protocol-v2.txt
> +++ b/Documentation/technical/protocol-v2.txt
> @@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:
> 
>    * '0000' Flush Packet (flush-pkt) - indicates the end of a message
>    * '0001' Delimiter Packet (delim-pkt) - separates sections of a message
> -  * '0002' Message Packet (response-end-pkt) - indicates the end of a response
> -    for stateless connections
> +  * '0002' Response End Packet (response-end-pkt) - indicates the end of a
> +    response for stateless connections
> 
>  Initial Client Request
>  ----------------------
> --
> 2.29.0.rc2
> 

← back to recent threads