{"thread":{"id":"55165","subject":"[OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt","startedAt":"2021-02-18T00:12:18Z","lastAt":"2021-02-18T03:50:01Z","messageCount":2,"participants":["Joey Salazar","Denton Liu"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"417263","messageId":"k1OL_yTjmhqRPUI_3wZNi4FpD0yadrwMKu1CaOXO07YyMBQG5hYoUKFtndt6mlNBKMxyCgm3JGf2YcENx-vRasj1W8keEI6ITVvkaqOi2_Q=@protonmail.com","threadId":"55165","inReplyTo":null,"subject":"[OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt","fromName":"Joey Salazar","fromEmail":"jgsal@protonmail.com","sentAt":"2021-02-18T00:11:22Z","receivedAt":"2021-02-18T00:12:18Z","isPatch":true,"sender":{"key":"jgsal@protonmail.com","avatar":null},"body":"Git Protocol version 2[1] defines 0002 as a Message Packet that indicates\nthe end of a response for stateless connections.\n\nChange the naming of the 0002 Packet to 'Response End' to match the\nparsing introduced in Wireshark's MR !1922 for consistency. A subsequent\nMR in Wireshark will address additional mismatches.\n\n[1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html\n[2] gitlab.com/wireshark/wireshark/-/merge_requests/1922\n\nSigned-off-by: Joey Salazar <jgsal@protonmail.com>\n---\n Documentation/technical/protocol-v2.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt\nindex e597b74da39..fc163ca605c 100644\n--- a/Documentation/technical/protocol-v2.txt\n+++ b/Documentation/technical/protocol-v2.txt\n@@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:\n\n   * '0000' Flush Packet (flush-pkt) - indicates the end of a message\n   * '0001' Delimiter Packet (delim-pkt) - separates sections of a message\n-  * '0002' Message Packet (response-end-pkt) - indicates the end of a response\n-    for stateless connections\n+  * '0002' Response End Packet (response-end-pkt) - indicates the end of a\n+    response for stateless connections\n\n Initial Client Request\n ----------------------\n--\n2.29.0.rc2\n\n"},{"id":"417282","messageId":"YC3ju7Jg9TyvRF2d@generichostname","threadId":"55165","inReplyTo":"k1OL_yTjmhqRPUI_3wZNi4FpD0yadrwMKu1CaOXO07YyMBQG5hYoUKFtndt6mlNBKMxyCgm3JGf2YcENx-vRasj1W8keEI6ITVvkaqOi2_Q=@protonmail.com","subject":"Re: [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2021-02-18T03:49:15Z","receivedAt":"2021-02-18T03:50:01Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"On Thu, Feb 18, 2021 at 12:11:22AM +0000, Joey Salazar wrote:\n> Git Protocol version 2[1] defines 0002 as a Message Packet that indicates\n> the end of a response for stateless connections.\n> \n> Change the naming of the 0002 Packet to 'Response End' to match the\n> parsing introduced in Wireshark's MR !1922 for consistency. A subsequent\n> MR in Wireshark will address additional mismatches.\n> \n> [1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html\n> [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922\n> \n> Signed-off-by: Joey Salazar <jgsal@protonmail.com>\n\nReviewed-by: Denton Liu <liu.denton@gmail.com>\n\n> ---\n>  Documentation/technical/protocol-v2.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt\n> index e597b74da39..fc163ca605c 100644\n> --- a/Documentation/technical/protocol-v2.txt\n> +++ b/Documentation/technical/protocol-v2.txt\n> @@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:\n> \n>    * '0000' Flush Packet (flush-pkt) - indicates the end of a message\n>    * '0001' Delimiter Packet (delim-pkt) - separates sections of a message\n> -  * '0002' Message Packet (response-end-pkt) - indicates the end of a response\n> -    for stateless connections\n> +  * '0002' Response End Packet (response-end-pkt) - indicates the end of a\n> +    response for stateless connections\n> \n>  Initial Client Request\n>  ----------------------\n> --\n> 2.29.0.rc2\n> \n"}]}