threads / discuss / 55056

Null pointer dereference in error pathway on git pull

Subject: Null pointer dereference in error pathway on git pull

## tl;dr

3 messages between Jan 26, 2021 and Jan 27, 2021.

replies: 2people: 2as markdown or json

Joshua Hudson· Jan 26, 2021, 20:31 UTC · lore

>git pull

remote: Azure Repos
remote: Found 452 objects to send. (157 ms)
Rfatal: the remote end hung up unexpectedly
fatal: early EOFs:  81% (367/452)
fatal: index-pack failed
warning: unable to unlink '(NULL)': Invalid argument

So it hits some kind of error (looks like network disconnect) and tries to back out; passed a NULL pointer to unlink().

Apologies if this has been submitted before. A search didn't find it.

Jeff King· Jan 26, 2021, 22:55 UTC · re: Joshua Hudson · lore

Re: Null pointer dereference in error pathway on git pull

On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:

Show 13 quoted lines

> >git pull
> remote: Azure Repos
> remote: Found 452 objects to send. (157 ms)
> Rfatal: the remote end hung up unexpectedly
> fatal: early EOFs:  81% (367/452)
> fatal: index-pack failed
> warning: unable to unlink '(NULL)': Invalid argument
> 
> 
> So it hits some kind of error (looks like network disconnect) and tries
> to back out; passed a NULL pointer to unlink().
> 
> Apologies if this has been submitted before. A search didn't find it.

Which version of Git are you using? It sounds like the same bug fixed by 6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30). That's in v2.30.0.

-Peff

Joshua Hudson· Jan 26, 2021, 23:01 UTC · re: Jeff King · lore

Re: Null pointer dereference in error pathway on git pull

2.29.2; yeah it does look like it could be the same bug

On 1/26/2021 2:55 PM, Jeff King wrote:

Show 20 quoted lines

> On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:
>
>>> git pull
>> remote: Azure Repos
>> remote: Found 452 objects to send. (157 ms)
>> Rfatal: the remote end hung up unexpectedly
>> fatal: early EOFs:  81% (367/452)
>> fatal: index-pack failed
>> warning: unable to unlink '(NULL)': Invalid argument
>>
>>
>> So it hits some kind of error (looks like network disconnect) and tries
>> to back out; passed a NULL pointer to unlink().
>>
>> Apologies if this has been submitted before. A search didn't find it.
> Which version of Git are you using? It sounds like the same bug fixed by
> 6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).
> That's in v2.30.0.
>
> -Peff