{"thread":{"id":"55056","subject":"Null pointer dereference in error pathway on git pull","startedAt":"2021-01-26T22:19:57Z","lastAt":"2021-01-27T12:26:22Z","messageCount":3,"participants":["Joshua Hudson","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"415351","messageId":"1cda3398-7b02-edc5-aaab-c75191124b80@cedaron.com","threadId":"55056","inReplyTo":null,"subject":"Null pointer dereference in error pathway on git pull","fromName":"Joshua Hudson","fromEmail":"jhudson@cedaron.com","sentAt":"2021-01-26T20:31:30Z","receivedAt":"2021-01-26T22:19:57Z","isPatch":false,"sender":{"key":"jhudson@cedaron.com","avatar":null},"body":">git pull\nremote: Azure Repos\nremote: Found 452 objects to send. (157 ms)\nRfatal: the remote end hung up unexpectedly\nfatal: early EOFs:  81% (367/452)\nfatal: index-pack failed\nwarning: unable to unlink '(NULL)': Invalid argument\n\n\nSo it hits some kind of error (looks like network disconnect) and tries\nto back out; passed a NULL pointer to unlink().\n\nApologies if this has been submitted before. A search didn't find it.\n\n"},{"id":"415412","messageId":"f8b3b05a-db46-1977-6fb4-ed13ac48e131@cedaron.com","threadId":"55056","inReplyTo":"YBCd2ZAumP65yrUK@coredump.intra.peff.net","subject":"Re: Null pointer dereference in error pathway on git pull","fromName":"Joshua Hudson","fromEmail":"jhudson@cedaron.com","sentAt":"2021-01-26T23:01:32Z","receivedAt":"2021-01-27T10:24:30Z","isPatch":false,"sender":{"key":"jhudson@cedaron.com","avatar":null},"body":"2.29.2; yeah it does look like it could be the same bug\n\nOn 1/26/2021 2:55 PM, Jeff King wrote:\n> On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:\n>\n>>> git pull\n>> remote: Azure Repos\n>> remote: Found 452 objects to send. (157 ms)\n>> Rfatal: the remote end hung up unexpectedly\n>> fatal: early EOFs:  81% (367/452)\n>> fatal: index-pack failed\n>> warning: unable to unlink '(NULL)': Invalid argument\n>>\n>>\n>> So it hits some kind of error (looks like network disconnect) and tries\n>> to back out; passed a NULL pointer to unlink().\n>>\n>> Apologies if this has been submitted before. A search didn't find it.\n> Which version of Git are you using? It sounds like the same bug fixed by\n> 6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).\n> That's in v2.30.0.\n>\n> -Peff\n"},{"id":"415414","messageId":"YBCd2ZAumP65yrUK@coredump.intra.peff.net","threadId":"55056","inReplyTo":"1cda3398-7b02-edc5-aaab-c75191124b80@cedaron.com","subject":"Re: Null pointer dereference in error pathway on git pull","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-01-26T22:55:21Z","receivedAt":"2021-01-27T12:26:22Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:\n\n> >git pull\n> remote: Azure Repos\n> remote: Found 452 objects to send. (157 ms)\n> Rfatal: the remote end hung up unexpectedly\n> fatal: early EOFs:  81% (367/452)\n> fatal: index-pack failed\n> warning: unable to unlink '(NULL)': Invalid argument\n> \n> \n> So it hits some kind of error (looks like network disconnect) and tries\n> to back out; passed a NULL pointer to unlink().\n> \n> Apologies if this has been submitted before. A search didn't find it.\n\nWhich version of Git are you using? It sounds like the same bug fixed by\n6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).\nThat's in v2.30.0.\n\n-Peff\n"}]}