[PATCH] perf/fsmonitor: use test_must_be_empty helper

Nipunn Koorapati via GitGitGadget· Nov 25, 2020, 22:11 UTC · lore

From: Nipunn Koorapati <nipunn@dropbox.com>

Simplify test and make error messages more clear here. Per feedback from Junio in 33226af42b (t/perf/fsmonitor: improve error message if typoing hook name, 2020-10-26)

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
---
    perf/fsmonitor: use test_must_be_empty helper
    
    Simplify perf/fsmonitor test and make error messages more clear.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-799%2Fnipunn1313%2Fnk%2Ffsmonitor-test-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/799

 t/perf/p7519-fsmonitor.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Show changes to t/perf/p7519-fsmonitor.sh +1 −2

diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
index 163a13bea3..9b43342806 100755
--- a/t/perf/p7519-fsmonitor.sh
+++ b/t/perf/p7519-fsmonitor.sh
@@ -129,8 +129,7 @@ setup_for_fsmonitor() {
 
 	git config core.fsmonitor "$INTEGRATION_SCRIPT" &&
 	git update-index --fsmonitor 2>error &&
-	cat error &&
-	[ ! -s error ] # ensure no silent error
+	test_must_be_empty error  # ensure no silent error
 }
 
 test_perf_w_drop_caches () {

base-commit: b291b0a628020eedb10b6236d87fe25d295cea81

-- 
gitgitgadget

Derrick Stolee· Nov 30, 2020, 14:15 UTC · re: Nipunn Koorapati via GitGitGadget · lore

Re: [PATCH] perf/fsmonitor: use test_must_be_empty helper

On 11/25/2020 5:11 PM, Nipunn Koorapati via GitGitGadget wrote:

Show 6 quoted lines

> From: Nipunn Koorapati <nipunn@dropbox.com>
> 
> Simplify test and make error messages more clear here.
> Per feedback from Junio in
> 33226af42b (t/perf/fsmonitor: improve error message if typoing hook
> name, 2020-10-26)

Thanks, Nipunn. This patch looks good to me.

-Stolee

patchperf/fsmonitor: use test_must_be_empty helper