{"thread":{"id":"54715","subject":"[PATCH] perf/fsmonitor: use test_must_be_empty helper","startedAt":"2020-11-25T22:12:22Z","lastAt":"2020-11-30T14:16:35Z","messageCount":2,"participants":["Nipunn Koorapati via GitGitGadget","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"410810","messageId":"pull.799.git.1606342297403.gitgitgadget@gmail.com","threadId":"54715","inReplyTo":null,"subject":"[PATCH] perf/fsmonitor: use test_must_be_empty helper","fromName":"Nipunn Koorapati via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-11-25T22:11:37Z","receivedAt":"2020-11-25T22:12:22Z","isPatch":true,"sender":{"key":"nipunn1313@gmail.com","avatar":"https://gravatar.com/avatar/d0b19cc6499ffcae349d237d7166f5fa0fc29942783a61894ccdb5ee5246ac97?d=mp&s=160"},"body":"From: Nipunn Koorapati <nipunn@dropbox.com>\n\nSimplify test and make error messages more clear here.\nPer feedback from Junio in\n33226af42b (t/perf/fsmonitor: improve error message if typoing hook\nname, 2020-10-26)\n\nSigned-off-by: Nipunn Koorapati <nipunn@dropbox.com>\n---\n    perf/fsmonitor: use test_must_be_empty helper\n    \n    Simplify perf/fsmonitor test and make error messages more clear.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-799%2Fnipunn1313%2Fnk%2Ffsmonitor-test-cleanup-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/799\n\n t/perf/p7519-fsmonitor.sh | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh\nindex 163a13bea3..9b43342806 100755\n--- a/t/perf/p7519-fsmonitor.sh\n+++ b/t/perf/p7519-fsmonitor.sh\n@@ -129,8 +129,7 @@ setup_for_fsmonitor() {\n \n \tgit config core.fsmonitor \"$INTEGRATION_SCRIPT\" &&\n \tgit update-index --fsmonitor 2>error &&\n-\tcat error &&\n-\t[ ! -s error ] # ensure no silent error\n+\ttest_must_be_empty error  # ensure no silent error\n }\n \n test_perf_w_drop_caches () {\n\nbase-commit: b291b0a628020eedb10b6236d87fe25d295cea81\n-- \ngitgitgadget\n"},{"id":"410997","messageId":"e82aa6f3-af88-246e-6cf8-5d2320133a59@gmail.com","threadId":"54715","inReplyTo":"pull.799.git.1606342297403.gitgitgadget@gmail.com","subject":"Re: [PATCH] perf/fsmonitor: use test_must_be_empty helper","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-11-30T14:15:13Z","receivedAt":"2020-11-30T14:16:35Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 11/25/2020 5:11 PM, Nipunn Koorapati via GitGitGadget wrote:\n> From: Nipunn Koorapati <nipunn@dropbox.com>\n> \n> Simplify test and make error messages more clear here.\n> Per feedback from Junio in\n> 33226af42b (t/perf/fsmonitor: improve error message if typoing hook\n> name, 2020-10-26)\n\nThanks, Nipunn. This patch looks good to me.\n\n-Stolee\n"}]}