threads / patch / 54670

patcht3040: remove stale note

Subject: [PATCH] t3040: remove stale note

## tl;dr

3 messages between Nov 18, 2020 and Nov 19, 2020. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Nov 18, 2020, 19:25 UTC · lore
From: Johannes Schindelin <johannes.schindelin@gmx.de>

This comment was most likely a "note to self" during the development of 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is neither needed nor comprehensible at this point. Let's remove it.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t3040: remove stale note
    
    And yet another thing I noticed while working on 
    https://github.com/gitgitgadget/git/pull/762.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-793%2Fdscho%2Ft3040-and-default-branch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-793/dscho/t3040-and-default-branch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/793
 t/t3040-subprojects-basic.sh | 3 ---
 1 file changed, 3 deletions(-)
Show changes to t/t3040-subprojects-basic.sh +0 −3
diff --git a/t/t3040-subprojects-basic.sh b/t/t3040-subprojects-basic.sh
index b81eb5fd6f..6abdcbbc94 100755
--- a/t/t3040-subprojects-basic.sh
+++ b/t/t3040-subprojects-basic.sh
@@ -79,7 +79,4 @@ test_expect_success 'checkout in superproject' '
 	git diff-index --exit-code --raw --cached save -- sub1
 '
 
-# just interesting what happened...
-# git diff --name-status -M save master
-
 test_done

base-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500

-- 
gitgitgadget
Junio C Hamano· Nov 18, 2020, 20:50 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] t3040: remove stale note

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This comment was most likely a "note to self" during the development of
> 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is
> neither needed nor comprehensible at this point. Let's remove it.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>     t3040: remove stale note
>     
>     And yet another thing I noticed while working on 
>     https://github.com/gitgitgadget/git/pull/762.

It seems that all test updates from you today are some form of refinement to the 27-patch series we have in 'seen'. I'll resolve conflicts in favor of these new ones as they look strict improvement (modulo @{2} thing I mentioned separately) in the meantime, but let's not forget to remove them from a reroll of the large series.

Thanks.
Johannes Schindelin· Nov 19, 2020, 11:23 UTC · re: Junio C Hamano · lore

Re: [PATCH] t3040: remove stale note

Hi Junio,
On Wed, 18 Nov 2020, Junio C Hamano wrote:
Show 21 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This comment was most likely a "note to self" during the development of
> > 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is
> > neither needed nor comprehensible at this point. Let's remove it.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     t3040: remove stale note
> >
> >     And yet another thing I noticed while working on
> >     https://github.com/gitgitgadget/git/pull/762.
>
> It seems that all test updates from you today are some form of
> refinement to the 27-patch series we have in 'seen'.  I'll resolve
> conflicts in favor of these new ones as they look strict improvement
> (modulo @{2} thing I mentioned separately) in the meantime, but
> let's not forget to remove them from a reroll of the large series.

I didn't ;-) See https://lore.kernel.org/git/pull.762.v3.git.1605743086.gitgitgadget@gmail.com/

Ciao, Dscho

← back to recent threads