{"thread":{"id":"54670","subject":"[PATCH] t3040: remove stale note","startedAt":"2020-11-18T19:25:51Z","lastAt":"2020-11-19T11:23:16Z","messageCount":3,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"410265","messageId":"pull.793.git.1605727526797.gitgitgadget@gmail.com","threadId":"54670","inReplyTo":null,"subject":"[PATCH] t3040: remove stale note","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-11-18T19:25:26Z","receivedAt":"2020-11-18T19:25:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nThis comment was most likely a \"note to self\" during the development of\n1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is\nneither needed nor comprehensible at this point. Let's remove it.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    t3040: remove stale note\n    \n    And yet another thing I noticed while working on \n    https://github.com/gitgitgadget/git/pull/762.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-793%2Fdscho%2Ft3040-and-default-branch-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-793/dscho/t3040-and-default-branch-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/793\n\n t/t3040-subprojects-basic.sh | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/t/t3040-subprojects-basic.sh b/t/t3040-subprojects-basic.sh\nindex b81eb5fd6f..6abdcbbc94 100755\n--- a/t/t3040-subprojects-basic.sh\n+++ b/t/t3040-subprojects-basic.sh\n@@ -79,7 +79,4 @@ test_expect_success 'checkout in superproject' '\n \tgit diff-index --exit-code --raw --cached save -- sub1\n '\n \n-# just interesting what happened...\n-# git diff --name-status -M save master\n-\n test_done\n\nbase-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500\n-- \ngitgitgadget\n"},{"id":"410273","messageId":"xmqqwnyiz8x3.fsf@gitster.c.googlers.com","threadId":"54670","inReplyTo":"pull.793.git.1605727526797.gitgitgadget@gmail.com","subject":"Re: [PATCH] t3040: remove stale note","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-11-18T20:50:32Z","receivedAt":"2020-11-18T20:51:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> From: Johannes Schindelin <johannes.schindelin@gmx.de>\n>\n> This comment was most likely a \"note to self\" during the development of\n> 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is\n> neither needed nor comprehensible at this point. Let's remove it.\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n>     t3040: remove stale note\n>     \n>     And yet another thing I noticed while working on \n>     https://github.com/gitgitgadget/git/pull/762.\n\nIt seems that all test updates from you today are some form of\nrefinement to the 27-patch series we have in 'seen'.  I'll resolve\nconflicts in favor of these new ones as they look strict improvement\n(modulo @{2} thing I mentioned separately) in the meantime, but\nlet's not forget to remove them from a reroll of the large series.\n\nThanks.\n"},{"id":"410346","messageId":"nycvar.QRO.7.76.6.2011191222020.56@tvgsbejvaqbjf.bet","threadId":"54670","inReplyTo":"xmqqwnyiz8x3.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] t3040: remove stale note","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-11-19T11:23:10Z","receivedAt":"2020-11-19T11:23:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Wed, 18 Nov 2020, Junio C Hamano wrote:\n\n> \"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\n> writes:\n>\n> > From: Johannes Schindelin <johannes.schindelin@gmx.de>\n> >\n> > This comment was most likely a \"note to self\" during the development of\n> > 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is\n> > neither needed nor comprehensible at this point. Let's remove it.\n> >\n> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> > ---\n> >     t3040: remove stale note\n> >\n> >     And yet another thing I noticed while working on\n> >     https://github.com/gitgitgadget/git/pull/762.\n>\n> It seems that all test updates from you today are some form of\n> refinement to the 27-patch series we have in 'seen'.  I'll resolve\n> conflicts in favor of these new ones as they look strict improvement\n> (modulo @{2} thing I mentioned separately) in the meantime, but\n> let's not forget to remove them from a reroll of the large series.\n\nI didn't ;-) See\nhttps://lore.kernel.org/git/pull.762.v3.git.1605743086.gitgitgadget@gmail.com/\n\nCiao,\nDscho\n"}]}