threads / patch / 5467

patchgit-repack: clear out tmp packfiles from $PACKDIR instead of cwd

Subject: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd

## tl;dr

4 messages between Sep 4, 2006 and Sep 4, 2006. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Martin Langhoff· Sep 4, 2006, 05:42 UTC · lore

Temp packfiles should never be created in cwd anyway ;-)

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-repack.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to git-repack.sh +2 −2

diff --git a/git-repack.sh b/git-repack.sh
index ccc8e43..eee0d72 100755
--- a/git-repack.sh
+++ b/git-repack.sh
@@ -24,8 +24,9 @@ do
 	shift
 done
 
-rm -f .tmp-pack-*
 PACKDIR="$GIT_OBJECT_DIRECTORY/pack"
+mkdir -p "$PACKDIR" || exit
+rm -f "$PACKDIR/.tmp-pack-*"
 
 # There will be more repacking strategies to come...
 case ",$all_into_one," in
@@ -43,7 +44,6 @@ case ",$all_into_one," in
 	;;
 esac
 
-mkdir -p "$PACKDIR" || exit
 pack_objects="$pack_objects $local $quiet $no_reuse_delta$extra"
 name=$( { git-rev-list --objects --all $rev_list ||
 	  echo "git-rev-list died with exit code $?"

-- 
1.4.2.gdfe7


-- 
VGER BF report: U 0.983488

Martin Langhoff· Sep 4, 2006, 05:48 UTC · re: Martin Langhoff · lore

Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd

On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:

> Temp packfiles should never be created in cwd anyway ;-)

Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"

> VGER BF report: U 0.983488

Hilarious!

-- 
VGER BF report: U 0.569396

Jakub Narebski· Sep 4, 2006, 08:17 UTC · re: Martin Langhoff · lore

Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd

Martin Langhoff wrote:

Show 8 quoted lines

> On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:
>> Temp packfiles should never be created in cwd anyway ;-)
> 
> Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"
> 
>> VGER BF report: U 0.983488
> 
> Hilarious!

Isn't 'U' for Undecided? (and 'H' for Ham)?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git



-- 
VGER BF report: S 0.999453

Martin Langhoff· Sep 4, 2006, 12:16 UTC · re: Jakub Narebski · lore

Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd

On 9/4/06, Jakub Narebski <jnareb@gmail.com> wrote:

Show 12 quoted lines

> Martin Langhoff wrote:
>
> > On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:
> >> Temp packfiles should never be created in cwd anyway ;-)
> >
> > Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"
> >
> >> VGER BF report: U 0.983488
> >
> > Hilarious!
>
> Isn't 'U' for Undecided? (and 'H' for Ham)?

Maybe -- but the score is really high. This patch was part of a series of 2 actually. The other one had a score of 1.6 and got bounced. :-/

martin

-- 
VGER BF report: U 0.558927