# [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd

4 messages from 2006-09-04 to 2006-09-04. Participants: Martin Langhoff, Jakub Narebski.
Thread: https://gitlist.dev/t/5467

## Martin Langhoff, 2006-09-04 05:42

Subject: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd
Message-ID: <11573485362686-git-send-email-martin@catalyst.net.nz>
URL: https://gitlist.dev/e/11573485362686-git-send-email-martin%40catalyst.net.nz

```
Temp packfiles should never be created in cwd anyway ;-)

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-repack.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-repack.sh b/git-repack.sh
index ccc8e43..eee0d72 100755
--- a/git-repack.sh
+++ b/git-repack.sh
@@ -24,8 +24,9 @@ do
 	shift
 done
 
-rm -f .tmp-pack-*
 PACKDIR="$GIT_OBJECT_DIRECTORY/pack"
+mkdir -p "$PACKDIR" || exit
+rm -f "$PACKDIR/.tmp-pack-*"
 
 # There will be more repacking strategies to come...
 case ",$all_into_one," in
@@ -43,7 +44,6 @@ case ",$all_into_one," in
 	;;
 esac
 
-mkdir -p "$PACKDIR" || exit
 pack_objects="$pack_objects $local $quiet $no_reuse_delta$extra"
 name=$( { git-rev-list --objects --all $rev_list ||
 	  echo "git-rev-list died with exit code $?"
-- 
1.4.2.gdfe7


-- 
VGER BF report: U 0.983488

```

## Martin Langhoff, 2006-09-04 05:48

Subject: Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd
Message-ID: <46a038f90609032248h5eda61dft4150e13e49f8e59e@mail.gmail.com>
URL: https://gitlist.dev/e/46a038f90609032248h5eda61dft4150e13e49f8e59e%40mail.gmail.com
In-Reply-To: <11573485362686-git-send-email-martin@catalyst.net.nz>

```
On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:
> Temp packfiles should never be created in cwd anyway ;-)

Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"

> VGER BF report: U 0.983488

Hilarious!


m

-- 
VGER BF report: U 0.569396

```

## Jakub Narebski, 2006-09-04 08:17

Subject: Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd
Message-ID: <edgndv$mtv$1@sea.gmane.org>
URL: https://gitlist.dev/e/edgndv%24mtv%241%40sea.gmane.org
In-Reply-To: <46a038f90609032248h5eda61dft4150e13e49f8e59e@mail.gmail.com>

```
Martin Langhoff wrote:

> On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:
>> Temp packfiles should never be created in cwd anyway ;-)
> 
> Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"
> 
>> VGER BF report: U 0.983488
> 
> Hilarious!

Isn't 'U' for Undecided? (and 'H' for Ham)?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git



-- 
VGER BF report: S 0.999453

```

## Martin Langhoff, 2006-09-04 12:16

Subject: Re: [PATCH] git-repack: clear out tmp packfiles from $PACKDIR instead of cwd
Message-ID: <46a038f90609040516y42d0250an85eea3c66bee31b6@mail.gmail.com>
URL: https://gitlist.dev/e/46a038f90609040516y42d0250an85eea3c66bee31b6%40mail.gmail.com
In-Reply-To: <edgndv$mtv$1@sea.gmane.org>

```
On 9/4/06, Jakub Narebski <jnareb@gmail.com> wrote:
> Martin Langhoff wrote:
>
> > On 9/4/06, Martin Langhoff <martin@catalyst.net.nz> wrote:
> >> Temp packfiles should never be created in cwd anyway ;-)
> >
> > Note! Applies after "git-repack: create new packs inside $PACKDIR, not cwd"
> >
> >> VGER BF report: U 0.983488
> >
> > Hilarious!
>
> Isn't 'U' for Undecided? (and 'H' for Ham)?

Maybe -- but the score is really high. This patch was part of a series
of 2 actually. The other one had a score of 1.6 and got bounced. :-/



martin

-- 
VGER BF report: U 0.558927

```