threads / discuss / 54565

Regression: cannot edit after intent-to-add

Subject: Regression: cannot edit after intent-to-add

## tl;dr

2 messages between Nov 3, 2020 and Nov 3, 2020.

replies: 1people: 2as markdown or json

Simon Richter· Nov 3, 2020, 17:16 UTC · lore

Hi,

I often create intermediate commits using hunk editing, which used to work in older versions even for new files, e.g.

    cat >file <<EOF
    foo
    bar
    EOF

    git add -N file

    git add -p file

git-add -p now shows me both lines as added, but does not allow me to edit. If I want to create an intermediate commit adding just one of the lines, I have to edit the actual file.

This used to work in older versions, as I remember using this technique for a while and recommending it to others.

Before I do a deep-dive into a codebase I haven't looked at in years: can this be re-added easily?

   Simon

Kyle Meyer· Nov 3, 2020, 17:44 UTC · re: Simon Richter · lore

Re: Regression: cannot edit after intent-to-add

Simon Richter writes:

Show 9 quoted lines

> git-add -p now shows me both lines as added, but does not allow me to edit.
> If I want to create an intermediate commit adding just one of the lines, I
> have to edit the actual file.
>
> This used to work in older versions, as I remember using this technique for
> a while and recommending it to others.
>
> Before I do a deep-dive into a codebase I haven't looked at in years: can
> this be re-added easily?

Which version of git are you using? I think this was already fixed by 75a009dc29 (add -p: fix editing of intent-to-add paths, 2020-09-09), which was included in v2.29.0.

https://lore.kernel.org/git/pull.731.git.1599659932391.gitgitgadget@gmail.com/