{"thread":{"id":"54565","subject":"Regression: cannot edit after intent-to-add","startedAt":"2020-11-03T17:24:55Z","lastAt":"2020-11-03T17:54:06Z","messageCount":2,"participants":["Simon Richter","Kyle Meyer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"409021","messageId":"20201103171618.GA28810@psi5.com","threadId":"54565","inReplyTo":null,"subject":"Regression: cannot edit after intent-to-add","fromName":"Simon Richter","fromEmail":"simon.richter@hogyros.de","sentAt":"2020-11-03T17:16:18Z","receivedAt":"2020-11-03T17:24:55Z","isPatch":false,"sender":{"key":"simon.richter@hogyros.de","avatar":"https://gravatar.com/avatar/1192aa9fa5dd19ce258b12b044cc27111dd7cdb58d920dc2123a02a24f55b5c5?d=mp&s=160"},"body":"Hi,\n\nI often create intermediate commits using hunk editing, which used to work\nin older versions even for new files, e.g.\n\n    cat >file <<EOF\n    foo\n    bar\n    EOF\n\n    git add -N file\n\n    git add -p file\n\ngit-add -p now shows me both lines as added, but does not allow me to edit.\nIf I want to create an intermediate commit adding just one of the lines, I\nhave to edit the actual file.\n\nThis used to work in older versions, as I remember using this technique for\na while and recommending it to others.\n\nBefore I do a deep-dive into a codebase I haven't looked at in years: can\nthis be re-added easily?\n\n   Simon\n"},{"id":"409023","messageId":"87eelamj2g.fsf@kyleam.com","threadId":"54565","inReplyTo":"20201103171618.GA28810@psi5.com","subject":"Re: Regression: cannot edit after intent-to-add","fromName":"Kyle Meyer","fromEmail":"kyle@kyleam.com","sentAt":"2020-11-03T17:44:23Z","receivedAt":"2020-11-03T17:54:06Z","isPatch":false,"sender":{"key":"kyle@kyleam.com","avatar":"https://avatars.githubusercontent.com/u/1297788?v=4"},"body":"Simon Richter writes:\n\n> git-add -p now shows me both lines as added, but does not allow me to edit.\n> If I want to create an intermediate commit adding just one of the lines, I\n> have to edit the actual file.\n>\n> This used to work in older versions, as I remember using this technique for\n> a while and recommending it to others.\n>\n> Before I do a deep-dive into a codebase I haven't looked at in years: can\n> this be re-added easily?\n\nWhich version of git are you using?  I think this was already fixed by\n75a009dc29 (add -p: fix editing of intent-to-add paths, 2020-09-09),\nwhich was included in v2.29.0.\n\nhttps://lore.kernel.org/git/pull.731.git.1599659932391.gitgitgadget@gmail.com/\n"}]}