threads / patch / 5447

patcht5710: fix two thinkos.

Subject: [PATCH] t5710: fix two thinkos.

## tl;dr

One message between Sep 1, 2006 and Sep 1, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Sep 1, 2006, 00:07 UTC · lore

The intention of the test seems to be to build a long chain of clones that locally borrow objects from their parents and see the system give up dereferencing long chains. There were two problems:

 (1) it did not test the right repository;
 (2) it did not build a chain long enough to trigger the limitation.

I do not think it is a good test to make sure the limitation the current implementation happens to have still exists, but that is a topic at a totally different level.

At least this fixes the broken test.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * Spotted this after the fix to git-fsck-objects by Linus not
   to require a valid HEAD.
 t/t5710-info-alternate.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to t/t5710-info-alternate.sh +2 −0
diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh
index 2e1b48a..b9f6d96 100755
--- a/t/t5710-info-alternate.sh
+++ b/t/t5710-info-alternate.sh
@@ -58,6 +58,8 @@ test_expect_failure 'creating too deep n
 git clone -l -s D E &&
 git clone -l -s E F &&
 git clone -l -s F G &&
+git clone -l -s G H &&
+cd H &&
 test_valid_repo'
 
 cd "$base_dir"
-- 
1.4.2.g2782

← back to recent threads