{"thread":{"id":"5447","subject":"[PATCH] t5710: fix two thinkos.","startedAt":"2006-09-01T00:07:08Z","lastAt":"2006-09-01T00:07:08Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"26176","messageId":"7vmz9k78lv.fsf@assigned-by-dhcp.cox.net","threadId":"5447","inReplyTo":null,"subject":"[PATCH] t5710: fix two thinkos.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-01T00:07:08Z","receivedAt":"2006-09-01T00:07:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The intention of the test seems to be to build a long chain of\nclones that locally borrow objects from their parents and see the\nsystem give up dereferencing long chains.  There were two problems:\n\n (1) it did not test the right repository;\n (2) it did not build a chain long enough to trigger the limitation.\n\nI do not think it is a good test to make sure the limitation the\ncurrent implementation happens to have still exists, but that is\na topic at a totally different level.\n\nAt least this fixes the broken test.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n\n * Spotted this after the fix to git-fsck-objects by Linus not\n   to require a valid HEAD.\n\n t/t5710-info-alternate.sh |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh\nindex 2e1b48a..b9f6d96 100755\n--- a/t/t5710-info-alternate.sh\n+++ b/t/t5710-info-alternate.sh\n@@ -58,6 +58,8 @@ test_expect_failure 'creating too deep n\n git clone -l -s D E &&\n git clone -l -s E F &&\n git clone -l -s F G &&\n+git clone -l -s G H &&\n+cd H &&\n test_valid_repo'\n \n cd \"$base_dir\"\n-- \n1.4.2.g2782\n"}]}