threads / patch / 54408

patchgit-gui: Make usettk off by default on Mac OS X

Subject: [PATCH] git-gui: Make usettk off by default on Mac OS X

## tl;dr

4 messages between Oct 13, 2020 and Oct 14, 2020. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Stefan Haller· Oct 13, 2020, 19:02 UTC · lore

This option is supposed to make a Tcl/Tk app look more like a native app for the respective platform. This doesn't seem to work on Mac, it looks worse than the non-ttk appearance (for instance, the colored pane headers are grey).

Users who really prefer the ttk look can still turn it on with the gui.usettk config.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 git-gui.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to git-gui.sh +1 −1
diff --git a/git-gui.sh b/git-gui.sh
index 867b8ce..f7e13ca 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
 set default_config(gui.fontdiff) [font configure font_diff]
 # TODO: this option should be added to the git-config documentation
 set default_config(gui.maxfilesdisplayed) 5000
-set default_config(gui.usettk) 1
+set default_config(gui.usettk) [expr ![is_MacOSX]]
 set default_config(gui.warndetachedcommit) 1
 set default_config(gui.tabsize) 8
 set font_descs {

-- 
2.29.0.rc1
Stefan Haller· Oct 13, 2020, 19:08 UTC · re: Stefan Haller · lore

Re: [PATCH] git-gui: Make usettk off by default on Mac OS X

On 13.10.20 21:02, Stefan Haller wrote:
Show 7 quoted lines
> This option is supposed to make a Tcl/Tk app look more like a native app
> for the respective platform. This doesn't seem to work on Mac, it looks
> worse than the non-ttk appearance (for instance, the colored pane
> headers are grey).
> 
> Users who really prefer the ttk look can still turn it on with the
> gui.usettk config.
Here's a screenshot with ttk on:
    https://cp.sync.com/dl/8c7693bc0/huvbc4f8-mkp8xzqc-nsevkr22-i4t4whwb
And this is with ttk off:
    https://cp.sync.com/dl/3a62604d0/756hqje2-mqqbanvc-aq3ghjd6-g7hw49xx
-Stefan
Pratyush Yadav· Oct 14, 2020, 10:01 UTC · re: Stefan Haller · lore

Re: [PATCH] git-gui: Make usettk off by default on Mac OS X

Hi Stefan,
On 13/10/20 09:02PM, Stefan Haller wrote:
> This option is supposed to make a Tcl/Tk app look more like a native app
> for the respective platform. This doesn't seem to work on Mac, it looks
> worse than the non-ttk appearance (for instance, the colored pane
> headers are grey).

I think we should actually fix the root of the problem instead of just fixing the symptoms by disabling ttk.

There were recently some changes to how git-gui works with ttk in commit c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you running git-gui with that commit? If yes, what results do you see with it reverted. If no, what results do you see with it applied?

Show 24 quoted lines
> Users who really prefer the ttk look can still turn it on with the
> gui.usettk config.
> 
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>  git-gui.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-gui.sh b/git-gui.sh
> index 867b8ce..f7e13ca 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
>  set default_config(gui.fontdiff) [font configure font_diff]
>  # TODO: this option should be added to the git-config documentation
>  set default_config(gui.maxfilesdisplayed) 5000
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) [expr ![is_MacOSX]]
>  set default_config(gui.warndetachedcommit) 1
>  set default_config(gui.tabsize) 8
>  set font_descs {
> -- 
> 2.29.0.rc1
> 
-- 
Regards,
Pratyush Yadav
Stefan Haller· Oct 14, 2020, 10:27 UTC · re: Pratyush Yadav · lore

Re: [PATCH] git-gui: Make usettk off by default on Mac OS X

On 14.10.20 12:01, Pratyush Yadav wrote:
Show 15 quoted lines
> Hi Stefan,
> 
> On 13/10/20 09:02PM, Stefan Haller wrote:
>> This option is supposed to make a Tcl/Tk app look more like a native app
>> for the respective platform. This doesn't seem to work on Mac, it looks
>> worse than the non-ttk appearance (for instance, the colored pane
>> headers are grey).
> 
> I think we should actually fix the root of the problem instead of just
> fixing the symptoms by disabling ttk.
> 
> There were recently some changes to how git-gui works with ttk in commit
> c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you
> running git-gui with that commit? If yes, what results do you see with
> it reverted. If no, what results do you see with it applied?

I agree that it would be better to fix the root cause; my suspicion was that the themed widgets on Mac simply don't support a background color, but I didn't investigate that any further.

I was indeed not running with "git-gui: improve dark mode support" yet, but applying it didn't make a difference.

I'm also happy to drop this if you are uncomfortable with it; it's easy enough to set gui.usettk to 0 to fix the problem locally.

Best, Stefan

← back to recent threads