{"thread":{"id":"54408","subject":"[PATCH] git-gui: Make usettk off by default on Mac OS X","startedAt":"2020-10-13T19:02:54Z","lastAt":"2020-10-14T10:27:27Z","messageCount":4,"participants":["Stefan Haller","Pratyush Yadav"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"407470","messageId":"20201013190243.62313-1-stefan@haller-berlin.de","threadId":"54408","inReplyTo":null,"subject":"[PATCH] git-gui: Make usettk off by default on Mac OS X","fromName":"Stefan Haller","fromEmail":"stefan@haller-berlin.de","sentAt":"2020-10-13T19:02:43Z","receivedAt":"2020-10-13T19:02:54Z","isPatch":true,"sender":{"key":"stefan@haller-berlin.de","avatar":"https://avatars.githubusercontent.com/u/1225667?v=4"},"body":"This option is supposed to make a Tcl/Tk app look more like a native app\nfor the respective platform. This doesn't seem to work on Mac, it looks\nworse than the non-ttk appearance (for instance, the colored pane\nheaders are grey).\n\nUsers who really prefer the ttk look can still turn it on with the\ngui.usettk config.\n\nSigned-off-by: Stefan Haller \n---\n git-gui.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 867b8ce..f7e13ca 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]\n set default_config(gui.fontdiff) [font configure font_diff]\n # TODO: this option should be added to the git-config documentation\n set default_config(gui.maxfilesdisplayed) 5000\n-set default_config(gui.usettk) 1\n+set default_config(gui.usettk) [expr ![is_MacOSX]]\n set default_config(gui.warndetachedcommit) 1\n set default_config(gui.tabsize) 8\n set font_descs {\n-- \n2.29.0.rc1\n\n"},{"id":"407473","messageId":"b3d1c303-b0e3-bba7-6bff-27f304e2c068@haller-berlin.de","threadId":"54408","inReplyTo":"20201013190243.62313-1-stefan@haller-berlin.de","subject":"Re: [PATCH] git-gui: Make usettk off by default on Mac OS X","fromName":"Stefan Haller","fromEmail":"stefan@haller-berlin.de","sentAt":"2020-10-13T19:08:21Z","receivedAt":"2020-10-13T19:13:42Z","isPatch":true,"sender":{"key":"stefan@haller-berlin.de","avatar":"https://avatars.githubusercontent.com/u/1225667?v=4"},"body":"On 13.10.20 21:02, Stefan Haller wrote:\n> This option is supposed to make a Tcl/Tk app look more like a native app\n> for the respective platform. This doesn't seem to work on Mac, it looks\n> worse than the non-ttk appearance (for instance, the colored pane\n> headers are grey).\n> \n> Users who really prefer the ttk look can still turn it on with the\n> gui.usettk config.\n\nHere's a screenshot with ttk on:\n\n https://cp.sync.com/dl/8c7693bc0/huvbc4f8-mkp8xzqc-nsevkr22-i4t4whwb\n\nAnd this is with ttk off:\n\n https://cp.sync.com/dl/3a62604d0/756hqje2-mqqbanvc-aq3ghjd6-g7hw49xx\n\n-Stefan\n\n"},{"id":"407500","messageId":"20201014100111.c43f2fqipc52dtsg@yadavpratyush.com","threadId":"54408","inReplyTo":"20201013190243.62313-1-stefan@haller-berlin.de","subject":"Re: [PATCH] git-gui: Make usettk off by default on Mac OS X","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2020-10-14T10:01:11Z","receivedAt":"2020-10-14T10:01:32Z","isPatch":true,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Stefan,\n\nOn 13/10/20 09:02PM, Stefan Haller wrote:\n> This option is supposed to make a Tcl/Tk app look more like a native app\n> for the respective platform. This doesn't seem to work on Mac, it looks\n> worse than the non-ttk appearance (for instance, the colored pane\n> headers are grey).\n\nI think we should actually fix the root of the problem instead of just \nfixing the symptoms by disabling ttk.\n\nThere were recently some changes to how git-gui works with ttk in commit \nc02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you \nrunning git-gui with that commit? If yes, what results do you see with \nit reverted. If no, what results do you see with it applied?\n\n> Users who really prefer the ttk look can still turn it on with the\n> gui.usettk config.\n> \n> Signed-off-by: Stefan Haller \n> ---\n> git-gui.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git-gui.sh b/git-gui.sh\n> index 867b8ce..f7e13ca 100755\n> --- a/git-gui.sh\n> +++ b/git-gui.sh\n> @@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]\n> set default_config(gui.fontdiff) [font configure font_diff]\n> # TODO: this option should be added to the git-config documentation\n> set default_config(gui.maxfilesdisplayed) 5000\n> -set default_config(gui.usettk) 1\n> +set default_config(gui.usettk) [expr ![is_MacOSX]]\n> set default_config(gui.warndetachedcommit) 1\n> set default_config(gui.tabsize) 8\n> set font_descs {\n> -- \n> 2.29.0.rc1\n> \n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"407502","messageId":"0aef1f02-5eed-41ed-c402-540fa50d79f1@haller-berlin.de","threadId":"54408","inReplyTo":"20201014100111.c43f2fqipc52dtsg@yadavpratyush.com","subject":"Re: [PATCH] git-gui: Make usettk off by default on Mac OS X","fromName":"Stefan Haller","fromEmail":"stefan@haller-berlin.de","sentAt":"2020-10-14T10:27:23Z","receivedAt":"2020-10-14T10:27:27Z","isPatch":true,"sender":{"key":"stefan@haller-berlin.de","avatar":"https://avatars.githubusercontent.com/u/1225667?v=4"},"body":"On 14.10.20 12:01, Pratyush Yadav wrote:\n> Hi Stefan,\n> \n> On 13/10/20 09:02PM, Stefan Haller wrote:\n>> This option is supposed to make a Tcl/Tk app look more like a native app\n>> for the respective platform. This doesn't seem to work on Mac, it looks\n>> worse than the non-ttk appearance (for instance, the colored pane\n>> headers are grey).\n> \n> I think we should actually fix the root of the problem instead of just\n> fixing the symptoms by disabling ttk.\n> \n> There were recently some changes to how git-gui works with ttk in commit\n> c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you\n> running git-gui with that commit? If yes, what results do you see with\n> it reverted. If no, what results do you see with it applied?\n\nI agree that it would be better to fix the root cause; my suspicion was \nthat the themed widgets on Mac simply don't support a background color, \nbut I didn't investigate that any further.\n\nI was indeed not running with \"git-gui: improve dark mode support\" yet, \nbut applying it didn't make a difference.\n\nI'm also happy to drop this if you are uncomfortable with it; it's easy \nenough to set gui.usettk to 0 to fix the problem locally.\n\nBest,\nStefan\n"}]}