threads / patch / 54313

patchconfig/uploadpack.txt: fix typo in `--filter=tree:<n>`

Subject: [PATCH] config/uploadpack.txt: fix typo in `--filter=tree:<n>`

## tl;dr

2 messages between Sep 27, 2020 and Sep 28, 2020. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Martin Ågren· Sep 27, 2020, 14:11 UTC · lore

That should be a ":", not a second "=". While at it, refer to the placeholder "<n>" as "<n>", not "n" (see, e.g., the entry just before this one).

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 On tb/upload-pack-filters.
 Documentation/config/uploadpack.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/config/uploadpack.txt +1 −1
diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt
index ee7b3ac94f..b0d761282c 100644
--- a/Documentation/config/uploadpack.txt
+++ b/Documentation/config/uploadpack.txt
@@ -65,17 +65,17 @@ uploadpackfilter.allow::
 uploadpackfilter.<filter>.allow::
 	Explicitly allow or ban the object filter corresponding to
 	`<filter>`, where `<filter>` may be one of: `blob:none`,
 	`blob:limit`, `tree`, `sparse:oid`, or `combine`. If using
 	combined filters, both `combine` and all of the nested filter
 	kinds must be allowed. Defaults to `uploadpackfilter.allow`.
 
 uploadpackfilter.tree.maxDepth::
-	Only allow `--filter=tree=<n>` when `n` is no more than the value of
+	Only allow `--filter=tree:<n>` when `<n>` is no more than the value of
 	`uploadpackfilter.tree.maxDepth`. If set, this also implies
 	`uploadpackfilter.tree.allow=true`, unless this configuration
 	variable had already been set. Has no effect if unset.
 
 uploadpack.allowRefInWant::
 	If this option is set, `upload-pack` will support the `ref-in-want`
 	feature of the protocol version 2 `fetch` command.  This feature
 	is intended for the benefit of load-balanced servers which may
-- 
2.28.0.277.g9b3c35fffd
Taylor Blau· Sep 28, 2020, 14:44 UTC · re: Martin Ågren · lore

Re: [PATCH] config/uploadpack.txt: fix typo in `--filter=tree:<n>`

Hi Martin,
On Sun, Sep 27, 2020 at 04:11:55PM +0200, Martin Ågren wrote:
> That should be a ":", not a second "=". While at it, refer to the
> placeholder "<n>" as "<n>", not "n" (see, e.g., the entry just before
> this one).
Thanks for catching this. The patch below looks great to me.
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
  Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

← back to recent threads