{"thread":{"id":"54313","subject":"[PATCH] config/uploadpack.txt: fix typo in `--filter=tree:<n>`","startedAt":"2020-09-27T14:12:18Z","lastAt":"2020-09-28T14:44:47Z","messageCount":2,"participants":["Martin Ågren","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"406497","messageId":"20200927141156.9878-1-martin.agren@gmail.com","threadId":"54313","inReplyTo":null,"subject":"[PATCH] config/uploadpack.txt: fix typo in `--filter=tree:<n>`","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2020-09-27T14:11:55Z","receivedAt":"2020-09-27T14:12:18Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"That should be a \":\", not a second \"=\". While at it, refer to the\nplaceholder \"<n>\" as \"<n>\", not \"n\" (see, e.g., the entry just before\nthis one).\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n On tb/upload-pack-filters.\n\n Documentation/config/uploadpack.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt\nindex ee7b3ac94f..b0d761282c 100644\n--- a/Documentation/config/uploadpack.txt\n+++ b/Documentation/config/uploadpack.txt\n@@ -65,17 +65,17 @@ uploadpackfilter.allow::\n uploadpackfilter.<filter>.allow::\n \tExplicitly allow or ban the object filter corresponding to\n \t`<filter>`, where `<filter>` may be one of: `blob:none`,\n \t`blob:limit`, `tree`, `sparse:oid`, or `combine`. If using\n \tcombined filters, both `combine` and all of the nested filter\n \tkinds must be allowed. Defaults to `uploadpackfilter.allow`.\n \n uploadpackfilter.tree.maxDepth::\n-\tOnly allow `--filter=tree=<n>` when `n` is no more than the value of\n+\tOnly allow `--filter=tree:<n>` when `<n>` is no more than the value of\n \t`uploadpackfilter.tree.maxDepth`. If set, this also implies\n \t`uploadpackfilter.tree.allow=true`, unless this configuration\n \tvariable had already been set. Has no effect if unset.\n \n uploadpack.allowRefInWant::\n \tIf this option is set, `upload-pack` will support the `ref-in-want`\n \tfeature of the protocol version 2 `fetch` command.  This feature\n \tis intended for the benefit of load-balanced servers which may\n-- \n2.28.0.277.g9b3c35fffd\n\n"},{"id":"406536","messageId":"20200928144440.GA3846176@nand.local","threadId":"54313","inReplyTo":"20200927141156.9878-1-martin.agren@gmail.com","subject":"Re: [PATCH] config/uploadpack.txt: fix typo in `--filter=tree:<n>`","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2020-09-28T14:44:40Z","receivedAt":"2020-09-28T14:44:47Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Martin,\n\nOn Sun, Sep 27, 2020 at 04:11:55PM +0200, Martin Ågren wrote:\n> That should be a \":\", not a second \"=\". While at it, refer to the\n> placeholder \"<n>\" as \"<n>\", not \"n\" (see, e.g., the entry just before\n> this one).\n\nThanks for catching this. The patch below looks great to me.\n\n> Signed-off-by: Martin Ågren <martin.agren@gmail.com>\n\n  Acked-by: Taylor Blau <me@ttaylorr.com>\n\nThanks,\nTaylor\n"}]}