threads / patch / 54143

patchgitk: use the 'reference' format for the commit reference

Subject: [PATCH] gitk: use the 'reference' format for the commit reference

## tl;dr

3 messages between Aug 27, 2020 and Aug 27, 2020. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Beat Bolli· Aug 27, 2020, 16:12 UTC · lore

Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in the main Git repository, there's an officially blessed format for commit references. Update gitk to also use this format.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 gitk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Show changes to gitk +1 −2

diff --git a/gitk b/gitk
index da84e22..b26996c 100755
--- a/gitk
+++ b/gitk
@@ -9433,8 +9433,7 @@ proc mktaggo {} {
 proc copyreference {} {
     global rowmenuid autosellen
 
-    set format "%h (\"%s\", %ad)"
-    set cmd [list git show -s --pretty=format:$format --date=short]
+    set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }

-- 
2.26.0.277.gb8618d28a9

Eric Sunshine· Aug 27, 2020, 16:26 UTC · re: Beat Bolli · lore

Re: [PATCH] gitk: use the 'reference' format for the commit reference

On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:

Show 5 quoted lines

> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
> the main Git repository, there's an officially blessed format for commit
> references. Update gitk to also use this format.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>

See this thread: https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/

Beat Bolli· Aug 27, 2020, 20:35 UTC · re: Eric Sunshine · lore

Re: [PATCH] gitk: use the 'reference' format for the commit reference

On 27.08.20 18:26, Eric Sunshine wrote:

Show 9 quoted lines

> On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:
>> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
>> the main Git repository, there's an officially blessed format for commit
>> references. Update gitk to also use this format.
>>
>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> 
> See this thread:
> https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/

Ooops, my memory is lacking!

Please ignore the noise...