{"thread":{"id":"54143","subject":"[PATCH] gitk: use the 'reference' format for the commit reference","startedAt":"2020-08-27T16:19:29Z","lastAt":"2020-08-27T20:49:06Z","messageCount":3,"participants":["Beat Bolli","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"404625","messageId":"20200827161224.824365-1-dev+git@drbeat.li","threadId":"54143","inReplyTo":null,"subject":"[PATCH] gitk: use the 'reference' format for the commit reference","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2020-08-27T16:12:24Z","receivedAt":"2020-08-27T16:19:29Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in\nthe main Git repository, there's an officially blessed format for commit\nreferences. Update gitk to also use this format.\n\nSigned-off-by: Beat Bolli <dev+git@drbeat.li>\n---\n gitk | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex da84e22..b26996c 100755\n--- a/gitk\n+++ b/gitk\n@@ -9433,8 +9433,7 @@ proc mktaggo {} {\n proc copyreference {} {\n     global rowmenuid autosellen\n \n-    set format \"%h (\\\"%s\\\", %ad)\"\n-    set cmd [list git show -s --pretty=format:$format --date=short]\n+    set cmd [list git show -s --pretty=reference]\n     if {$autosellen < 40} {\n         lappend cmd --abbrev=$autosellen\n     }\n-- \n2.26.0.277.gb8618d28a9\n\n"},{"id":"404626","messageId":"CAPig+cRZEgu4GfMGSWQbs4cV9OGT9z7gKh8v8S+_sWmKFJd4Sg@mail.gmail.com","threadId":"54143","inReplyTo":"20200827161224.824365-1-dev+git@drbeat.li","subject":"Re: [PATCH] gitk: use the 'reference' format for the commit reference","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2020-08-27T16:26:27Z","receivedAt":"2020-08-27T16:26:42Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:\n> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in\n> the main Git repository, there's an officially blessed format for commit\n> references. Update gitk to also use this format.\n>\n> Signed-off-by: Beat Bolli <dev+git@drbeat.li>\n\nSee this thread:\nhttps://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/\n"},{"id":"404656","messageId":"55bcebf4-5d5a-7133-35b8-c8780d7ee154@drbeat.li","threadId":"54143","inReplyTo":"CAPig+cRZEgu4GfMGSWQbs4cV9OGT9z7gKh8v8S+_sWmKFJd4Sg@mail.gmail.com","subject":"Re: [PATCH] gitk: use the 'reference' format for the commit reference","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2020-08-27T20:35:18Z","receivedAt":"2020-08-27T20:49:06Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"On 27.08.20 18:26, Eric Sunshine wrote:\n> On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:\n>> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in\n>> the main Git repository, there's an officially blessed format for commit\n>> references. Update gitk to also use this format.\n>>\n>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>\n> \n> See this thread:\n> https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/\n\nOoops, my memory is lacking!\n\nPlease ignore the noise...\n"}]}