threads / patch / 54056

patchDocumentation/git-send-email.txt: Mention less secure app access might need to enable.

Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

## tl;dr

9 messages between Aug 17, 2020 and Jan 7, 2021. Diffs are folded; open one to read it.

replies: 8people: 4as markdown or json

Vasyl Vavrychuk· Aug 17, 2020, 12:54 UTC · lore

Looks like Google changed gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Show changes to Documentation/git-send-email.txt +5 −1
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..5aed3f5b1d 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
+If you do not have multifactor authentication setup on your gmail account, you
+need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 If you have multifactor authentication setup on your gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
@@ -505,7 +509,7 @@ following commands:
 	$ edit outgoing/0000-*
 	$ git send-email outgoing/*
 
-The first time you run it, you will be prompted for your credentials.  Enter the
+The first time you run it, you will be prompted for your credentials. Enter the
 app-specific or your regular password as appropriate.  If you have credential
 helper configured (see linkgit:git-credential[1]), the password will be saved in
 the credential store so you won't have to type it the next time.

-- 
2.23.0
Eric Sunshine· Aug 17, 2020, 17:16 UTC · re: Vasyl Vavrychuk · lore

Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

On Mon, Aug 17, 2020 at 8:54 AM Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:
Show 7 quoted lines
> Looks like Google changed gmail security and now less secure app access
> needs to be explicitly enabled if 2-factor authentication is not in
> place, otherwise send-mail fails with:
>
>   5.7.8 Username and Password not accepted. Learn more at
>   5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
> ---
Missing sign-off. Please see Documentation/SubmittingPatches.
Show 5 quoted lines
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> @@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
> +If you do not have multifactor authentication setup on your gmail account, you
> +need to allow less secure app access. Visit
> +https://myaccount.google.com/lesssecureapps to enable it.
Thanks. Make sense. A few comments:

I think multi-factor is usually hyphenated, so perhaps: s/multifactor/multi-factor/

Since you are not using it as a noun: s/setup/set up/
Also, Gmail is normally capitalized, so: s/gmail/Gmail
> @@ -505,7 +509,7 @@ following commands:
> -The first time you run it, you will be prompted for your credentials.  Enter the
> +The first time you run it, you will be prompted for your credentials. Enter the

This unnecessary whitespace change just adds noise to the patch, thus should be dropped.

Vasyl Vavrychuk· Aug 29, 2020, 15:39 UTC · re: Eric Sunshine · lore

Looks like Google changed Gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Show changes to Documentation/git-send-email.txt +5 −1
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..06953fd1e0 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you do not have multi-factor authentication set up on your Gmail account, you
+will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 

-- 
2.23.0
Junio C Hamano· Aug 29, 2020, 18:33 UTC · re: Vasyl Vavrychuk · lore

Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
> Looks like Google changed Gmail security and now less secure app access
> needs to be explicitly enabled if 2-factor authentication is not in
> place, otherwise send-mail fails with:
'send-email' I presume?
>   5.7.8 Username and Password not accepted. Learn more at
>   5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

Is the v5sm1375... part stay constant that everybody would get the same thing?

Otherwise,
    ... otherwise send-email fails with an error message from Gmail
    server telling the user to "Learn more" at 
    https://support.google.com/mail/?p=BadCredentials
would be preferrable.
Show 21 quoted lines
> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> ---
>  Documentation/git-send-email.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 0a69810147..06953fd1e0 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
>  	smtpServerPort = 587
>  ----
>  
> -If you have multifactor authentication setup on your gmail account, you will
> +If you do not have multi-factor authentication set up on your Gmail account, you
> +will need to allow less secure app access. Visit
> +https://myaccount.google.com/lesssecureapps to enable it.
> +
> +If you have multi-factor authentication set up on your Gmail account, you will
>  need to generate an app-specific password for use with 'git send-email'. Visit
>  https://security.google.com/settings/security/apppasswords to create it.

In 2020, we should probably list the instruction for those with 2 factor first and then give "less secure app access" as a fallback. IOW, I'd suggest the order of these two paragraphs swapped.

Thanks.
Junio C Hamano· Aug 29, 2020, 19:29 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Junio C Hamano <gitster@pobox.com> writes:
> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
Another thing I forgot to say.
Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Especially with grammofix s/to enable/to be enabled/ applied, the above is way too long as a title and would stand out like a sore thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output. Something like

Subject: [PATCH] send-email doc: mention less secure app access with GMail
perhaps.
Thanks.
Junio C Hamano· Sep 6, 2020, 21:52 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
>
> Another thing I forgot to say.
>
> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.
>
> Especially with grammofix s/to enable/to be enabled/ applied, the
> above is way too long as a title and would stand out like a sore
> thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output.
> Something like
>
> Subject: [PATCH] send-email doc: mention less secure app access with GMail
>
> perhaps.
>
> Thanks.

Anything new on this topic? No rush, but I'd hate to see a basically good topic to be left in the stalled state too long.

Junio C Hamano· Dec 22, 2020, 19:58 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Junio C Hamano <gitster@pobox.com> writes:
Show 23 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
>>
>> Another thing I forgot to say.
>>
>> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.
>>
>> Especially with grammofix s/to enable/to be enabled/ applied, the
>> above is way too long as a title and would stand out like a sore
>> thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output.
>> Something like
>>
>> Subject: [PATCH] send-email doc: mention less secure app access with GMail
>>
>> perhaps.
>>
>> Thanks.
>
> Anything new on this topic?  No rush, but I'd hate to see a
> basically good topic to be left in the stalled state too long.

Just pinging old threads that we have been expecting a reroll, but it has been more than 3 months. Has an update been sent that I missed?

Thanks.
Denton Liu· Jan 7, 2021, 11:11 UTC · re: Vasyl Vavrychuk · lore

[PATCH v3] git-send-email.txt: mention less secure app access with Gmail

Google may have changed Gmail security and now less secure app access needs to be explicitly enabled if two-factor authentication is not in place, otherwise send-email fails with:

	5.7.8 Username and Password not accepted. Learn more at
	5.7.8  https://support.google.com/mail/?p=BadCredentials
Document steps required to make this work.
Original-patch-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
Range-diff against v2:
1:  2bcfd1403f < -:  ---------- Documentation/git-send-email.txt: Mention less secure app access might need to enable.
-:  ---------- > 1:  274475559a git-send-email.txt: mention less secure app access with Gmail
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Show changes to Documentation/git-send-email.txt +5 −1
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..0db0783f2f 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -494,10 +494,14 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 
+If you do not have multi-factor authentication set up on your Gmail account,
+you will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 Once your commits are ready to be sent to the mailing list, run the
 following commands:
 

-- 
2.30.0
Eric Sunshine· Jan 7, 2021, 20:37 UTC · re: Denton Liu · lore

Re: [PATCH v3] git-send-email.txt: mention less secure app access with Gmail

On Thu, Jan 7, 2021 at 6:12 AM Denton Liu <liu.denton@gmail.com> wrote:
Show 11 quoted lines
> Google may have changed Gmail security and now less secure app access
> needs to be explicitly enabled if two-factor authentication is not in
> place, otherwise send-email fails with:
>
>         5.7.8 Username and Password not accepted. Learn more at
>         5.7.8  https://support.google.com/mail/?p=BadCredentials
>
> Document steps required to make this work.
>
> Original-patch-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
Thanks for picking this up.

Has this version changed in any substantial way from Vasyl's v2[1]? If not, perhaps it makes sense to retain his authorship and sign-off.

[1]: https://lore.kernel.org/git/20200829153920.17155-1-vvavrychuk@gmail.com/

← back to recent threads