{"thread":{"id":"54056","subject":"[PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","startedAt":"2020-08-17T12:54:37Z","lastAt":"2021-01-07T20:38:04Z","messageCount":9,"participants":["Vasyl Vavrychuk","Eric Sunshine","Junio C Hamano","Denton Liu"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"403814","messageId":"20200817125419.1655-1-vvavrychuk@gmail.com","threadId":"54056","inReplyTo":null,"subject":"[PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Vasyl Vavrychuk","fromEmail":"vvavrychuk@gmail.com","sentAt":"2020-08-17T12:54:19Z","receivedAt":"2020-08-17T12:54:37Z","isPatch":true,"sender":{"key":"vvavrychuk@gmail.com","avatar":"https://avatars.githubusercontent.com/u/152563?v=4"},"body":"Looks like Google changed gmail security and now less secure app access\nneeds to be explicitly enabled if 2-factor authentication is not in\nplace, otherwise send-mail fails with:\n\n 5.7.8 Username and Password not accepted. Learn more at\n 5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp\n---\n Documentation/git-send-email.txt | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0a69810147..5aed3f5b1d 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:\n \tsmtpServerPort = 587\n ----\n \n+If you do not have multifactor authentication setup on your gmail account, you\n+need to allow less secure app access. Visit\n+https://myaccount.google.com/lesssecureapps to enable it.\n+\n If you have multifactor authentication setup on your gmail account, you will\n need to generate an app-specific password for use with 'git send-email'. Visit\n https://security.google.com/settings/security/apppasswords to create it.\n@@ -505,7 +509,7 @@ following commands:\n \t$ edit outgoing/0000-*\n \t$ git send-email outgoing/*\n \n-The first time you run it, you will be prompted for your credentials. Enter the\n+The first time you run it, you will be prompted for your credentials. Enter the\n app-specific or your regular password as appropriate. If you have credential\n helper configured (see linkgit:git-credential[1]), the password will be saved in\n the credential store so you won't have to type it the next time.\n-- \n2.23.0\n\n"},{"id":"403838","messageId":"CAPig+cT8Kmh6LcoKqkcJX6imXaase07o8C_-7k7RkyhEyW02rQ@mail.gmail.com","threadId":"54056","inReplyTo":"20200817125419.1655-1-vvavrychuk@gmail.com","subject":"Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2020-08-17T17:16:40Z","receivedAt":"2020-08-17T17:28:01Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Aug 17, 2020 at 8:54 AM Vasyl Vavrychuk wrote:\n> Looks like Google changed gmail security and now less secure app access\n> needs to be explicitly enabled if 2-factor authentication is not in\n> place, otherwise send-mail fails with:\n>\n> 5.7.8 Username and Password not accepted. Learn more at\n> 5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp\n> ---\n\nMissing sign-off. Please see Documentation/SubmittingPatches.\n\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> @@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:\n> +If you do not have multifactor authentication setup on your gmail account, you\n> +need to allow less secure app access. Visit\n> +https://myaccount.google.com/lesssecureapps to enable it.\n\nThanks. Make sense. A few comments:\n\nI think multi-factor is usually hyphenated, so perhaps:\ns/multifactor/multi-factor/\n\nSince you are not using it as a noun: s/setup/set up/\n\nAlso, Gmail is normally capitalized, so: s/gmail/Gmail\n\n> @@ -505,7 +509,7 @@ following commands:\n> -The first time you run it, you will be prompted for your credentials. Enter the\n> +The first time you run it, you will be prompted for your credentials. Enter the\n\nThis unnecessary whitespace change just adds noise to the patch, thus\nshould be dropped.\n"},{"id":"404749","messageId":"20200829153920.17155-1-vvavrychuk@gmail.com","threadId":"54056","inReplyTo":"CAPig+cT8Kmh6LcoKqkcJX6imXaase07o8C_-7k7RkyhEyW02rQ@mail.gmail.com","subject":"[PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Vasyl Vavrychuk","fromEmail":"vvavrychuk@gmail.com","sentAt":"2020-08-29T15:39:20Z","receivedAt":"2020-08-29T15:39:34Z","isPatch":true,"sender":{"key":"vvavrychuk@gmail.com","avatar":"https://avatars.githubusercontent.com/u/152563?v=4"},"body":"Looks like Google changed Gmail security and now less secure app access\nneeds to be explicitly enabled if 2-factor authentication is not in\nplace, otherwise send-mail fails with:\n\n 5.7.8 Username and Password not accepted. Learn more at\n 5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp\n\nSigned-off-by: Vasyl Vavrychuk \n---\n Documentation/git-send-email.txt | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0a69810147..06953fd1e0 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:\n \tsmtpServerPort = 587\n ----\n \n-If you have multifactor authentication setup on your gmail account, you will\n+If you do not have multi-factor authentication set up on your Gmail account, you\n+will need to allow less secure app access. Visit\n+https://myaccount.google.com/lesssecureapps to enable it.\n+\n+If you have multi-factor authentication set up on your Gmail account, you will\n need to generate an app-specific password for use with 'git send-email'. Visit\n https://security.google.com/settings/security/apppasswords to create it.\n \n-- \n2.23.0\n\n"},{"id":"404751","messageId":"xmqqwo1hi9nv.fsf@gitster.c.googlers.com","threadId":"54056","inReplyTo":"20200829153920.17155-1-vvavrychuk@gmail.com","subject":"Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-29T18:33:56Z","receivedAt":"2020-08-29T18:34:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Vasyl Vavrychuk writes:\n\n> Looks like Google changed Gmail security and now less secure app access\n> needs to be explicitly enabled if 2-factor authentication is not in\n> place, otherwise send-mail fails with:\n\n'send-email' I presume?\n\n> 5.7.8 Username and Password not accepted. Learn more at\n> 5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp\n\nIs the v5sm1375... part stay constant that everybody would get the\nsame thing?\n\nOtherwise,\n\n ... otherwise send-email fails with an error message from Gmail\n server telling the user to \"Learn more\" at \n https://support.google.com/mail/?p=BadCredentials\n\nwould be preferrable.\n\n> Signed-off-by: Vasyl Vavrychuk \n> ---\n> Documentation/git-send-email.txt | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 0a69810147..06953fd1e0 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:\n> \tsmtpServerPort = 587\n> ----\n> \n> -If you have multifactor authentication setup on your gmail account, you will\n> +If you do not have multi-factor authentication set up on your Gmail account, you\n> +will need to allow less secure app access. Visit\n> +https://myaccount.google.com/lesssecureapps to enable it.\n> +\n> +If you have multi-factor authentication set up on your Gmail account, you will\n> need to generate an app-specific password for use with 'git send-email'. Visit\n> https://security.google.com/settings/security/apppasswords to create it.\n\nIn 2020, we should probably list the instruction for those with 2\nfactor first and then give \"less secure app access\" as a fallback.\nIOW, I'd suggest the order of these two paragraphs swapped.\n\nThanks.\n\n"},{"id":"404757","messageId":"xmqqft85i72s.fsf@gitster.c.googlers.com","threadId":"54056","inReplyTo":"xmqqwo1hi9nv.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-08-29T19:29:47Z","receivedAt":"2020-08-29T19:29:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Vasyl Vavrychuk writes:\n\nAnother thing I forgot to say.\n\nSubject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.\n\nEspecially with grammofix s/to enable/to be enabled/ applied, the\nabove is way too long as a title and would stand out like a sore\nthumb in \"git shortlog --no-merges v2.28.0..v2.29.0\" output.\nSomething like\n\nSubject: [PATCH] send-email doc: mention less secure app access with GMail\n\nperhaps.\n\nThanks.\n"},{"id":"405099","messageId":"xmqqmu224lpm.fsf@gitster.c.googlers.com","threadId":"54056","inReplyTo":"xmqqft85i72s.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-06T21:52:21Z","receivedAt":"2020-09-06T21:52:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> Vasyl Vavrychuk writes:\n>\n> Another thing I forgot to say.\n>\n> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.\n>\n> Especially with grammofix s/to enable/to be enabled/ applied, the\n> above is way too long as a title and would stand out like a sore\n> thumb in \"git shortlog --no-merges v2.28.0..v2.29.0\" output.\n> Something like\n>\n> Subject: [PATCH] send-email doc: mention less secure app access with GMail\n>\n> perhaps.\n>\n> Thanks.\n\nAnything new on this topic? No rush, but I'd hate to see a\nbasically good topic to be left in the stalled state too long.\n"},{"id":"412854","messageId":"xmqqwnx9haus.fsf@gitster.c.googlers.com","threadId":"54056","inReplyTo":"xmqqmu224lpm.fsf@gitster.c.googlers.com","subject":"Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-12-22T19:58:03Z","receivedAt":"2020-12-22T19:58:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> Junio C Hamano writes:\n>>\n>>> Vasyl Vavrychuk writes:\n>>\n>> Another thing I forgot to say.\n>>\n>> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.\n>>\n>> Especially with grammofix s/to enable/to be enabled/ applied, the\n>> above is way too long as a title and would stand out like a sore\n>> thumb in \"git shortlog --no-merges v2.28.0..v2.29.0\" output.\n>> Something like\n>>\n>> Subject: [PATCH] send-email doc: mention less secure app access with GMail\n>>\n>> perhaps.\n>>\n>> Thanks.\n>\n> Anything new on this topic? No rush, but I'd hate to see a\n> basically good topic to be left in the stalled state too long.\n\nJust pinging old threads that we have been expecting a reroll, but\nit has been more than 3 months. Has an update been sent that I\nmissed?\n\nThanks.\n"},{"id":"413681","messageId":"274475559a6de9c95c9c6cd30b5d056a31cc2853.1610017875.git.liu.denton@gmail.com","threadId":"54056","inReplyTo":"20200829153920.17155-1-vvavrychuk@gmail.com","subject":"[PATCH v3] git-send-email.txt: mention less secure app access with Gmail","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2021-01-07T11:11:49Z","receivedAt":"2021-01-07T11:12:45Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"Google may have changed Gmail security and now less secure app access\nneeds to be explicitly enabled if two-factor authentication is not in\nplace, otherwise send-email fails with:\n\n\t5.7.8 Username and Password not accepted. Learn more at\n\t5.7.8 https://support.google.com/mail/?p=BadCredentials\n\nDocument steps required to make this work.\n\nOriginal-patch-by: Vasyl Vavrychuk \nSigned-off-by: Denton Liu \n---\nRange-diff against v2:\n1: 2bcfd1403f < -: ---------- Documentation/git-send-email.txt: Mention less secure app access might need to enable.\n-: ---------- > 1: 274475559a git-send-email.txt: mention less secure app access with Gmail\n\n Documentation/git-send-email.txt | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 0a69810147..0db0783f2f 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -494,10 +494,14 @@ edit ~/.gitconfig to specify your account settings:\n \tsmtpServerPort = 587\n ----\n \n-If you have multifactor authentication setup on your gmail account, you will\n+If you have multi-factor authentication set up on your Gmail account, you will\n need to generate an app-specific password for use with 'git send-email'. Visit\n https://security.google.com/settings/security/apppasswords to create it.\n \n+If you do not have multi-factor authentication set up on your Gmail account,\n+you will need to allow less secure app access. Visit\n+https://myaccount.google.com/lesssecureapps to enable it.\n+\n Once your commits are ready to be sent to the mailing list, run the\n following commands:\n \n-- \n2.30.0\n\n"},{"id":"413743","messageId":"CAPig+cSG0WMs2TRVDOWxSsoRD2Qo_+kGm2QTGgQC+sLjyGZ9ow@mail.gmail.com","threadId":"54056","inReplyTo":"274475559a6de9c95c9c6cd30b5d056a31cc2853.1610017875.git.liu.denton@gmail.com","subject":"Re: [PATCH v3] git-send-email.txt: mention less secure app access with Gmail","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-01-07T20:37:11Z","receivedAt":"2021-01-07T20:38:04Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Jan 7, 2021 at 6:12 AM Denton Liu wrote:\n> Google may have changed Gmail security and now less secure app access\n> needs to be explicitly enabled if two-factor authentication is not in\n> place, otherwise send-email fails with:\n>\n> 5.7.8 Username and Password not accepted. Learn more at\n> 5.7.8 https://support.google.com/mail/?p=BadCredentials\n>\n> Document steps required to make this work.\n>\n> Original-patch-by: Vasyl Vavrychuk \n> Signed-off-by: Denton Liu \n\nThanks for picking this up.\n\nHas this version changed in any substantial way from Vasyl's v2[1]? If\nnot, perhaps it makes sense to retain his authorship and sign-off.\n\n[1]: https://lore.kernel.org/git/20200829153920.17155-1-vvavrychuk@gmail.com/\n"}]}