threads / patch / 52138

patchhelp: add gitsubmodules to the list of guides

Subject: [PATCH 1/1] help: add gitsubmodules to the list of guides

## tl;dr

3 messages between Oct 28, 2019 and Oct 28, 2019. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Philippe Blain via GitGitGadget· Oct 28, 2019, 13:05 UTC · lore

[PATCH 0/1] help: add gitsubmodules to the list of guides

The guide "gitsubmodules" was added in d480345 (submodules: overhaul documentation, 2017-06-22), but it was not added to command-list.txt when commit 1b81d8c (help: use command-list.txt for the source of guides, 2018-05-20) taught "git help" to obtain the guide list from this file.

Add it now.

Philippe Blain (1):
  help: add gitsubmodules to the list of guides

 Documentation/gitsubmodules.txt | 2 +-
 command-list.txt                | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

base-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-433%2Fphil-blain%2Fadd-gitsubmodules-to-guides-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-433/phil-blain/add-gitsubmodules-to-guides-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/433

-- 
gitgitgadget

Philippe Blain via GitGitGadget· Oct 28, 2019, 13:05 UTC · re: Philippe Blain via GitGitGadget · lore

From: Philippe Blain <levraiphilippeblain@gmail.com>

Add it now, and capitalize the first word of the description of gitsubmodules, as was done in 1b81d8c (help: use command-list.txt for the source of guides, 2018-05-20) for the other guides.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 Documentation/gitsubmodules.txt | 2 +-
 command-list.txt                | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Show changes to 2 files +2 −1

Documentation/gitsubmodules.txt, command-list.txt

diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
index 0a890205b8..c476f891b5 100644
--- a/Documentation/gitsubmodules.txt
+++ b/Documentation/gitsubmodules.txt
@@ -3,7 +3,7 @@ gitsubmodules(7)
 
 NAME
 ----
-gitsubmodules - mounting one repository inside another
+gitsubmodules - Mounting one repository inside another
 
 SYNOPSIS
 --------
diff --git a/command-list.txt b/command-list.txt
index a9ac72bef4..72e435c5a3 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -203,6 +203,7 @@ gitmodules                              guide
 gitnamespaces                           guide
 gitrepository-layout                    guide
 gitrevisions                            guide
+gitsubmodules                           guide
 gittutorial-2                           guide
 gittutorial                             guide
 gitworkflows                            guide

-- 
gitgitgadget

Jonathan Nieder· Oct 28, 2019, 21:51 UTC · re: Philippe Blain via GitGitGadget · lore

Re: [PATCH 1/1] help: add gitsubmodules to the list of guides

Philippe Blain wrote:

Show 15 quoted lines

> The guide "gitsubmodules" was added in d480345 (submodules: overhaul
> documentation, 2017-06-22), but it was not added to
> command-list.txt when commit 1b81d8c (help: use command-list.txt
> for the source of guides, 2018-05-20) taught "git help" to obtain the
> guide list from this file.
>
> Add it now, and capitalize the first word of the description of
> gitsubmodules, as was done in 1b81d8c (help: use command-list.txt
> for the source of guides, 2018-05-20) for the other guides.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
> ---
>  Documentation/gitsubmodules.txt | 2 +-
>  command-list.txt                | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

Good catch.  Thanks for taking care of it.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>