{"thread":{"id":"52138","subject":"[PATCH 1/1] help: add gitsubmodules to the list of guides","startedAt":"2019-10-28T13:05:51Z","lastAt":"2019-10-28T21:51:09Z","messageCount":3,"participants":["Philippe Blain via GitGitGadget","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"384987","messageId":"8026c7e9ab2f60af770fa66097d3220259201d8f.1572267946.git.gitgitgadget@gmail.com","threadId":"52138","inReplyTo":"pull.433.git.1572267946.gitgitgadget@gmail.com","subject":"[PATCH 1/1] help: add gitsubmodules to the list of guides","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-28T13:05:46Z","receivedAt":"2019-10-28T13:05:51Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"From: Philippe Blain <levraiphilippeblain@gmail.com>\n\nThe guide \"gitsubmodules\" was added in d480345 (submodules: overhaul\ndocumentation, 2017-06-22), but it was not added to\ncommand-list.txt when commit 1b81d8c (help: use command-list.txt\nfor the source of guides, 2018-05-20) taught \"git help\" to obtain the\nguide list from this file.\n\nAdd it now, and capitalize the first word of the description of\ngitsubmodules, as was done in 1b81d8c (help: use command-list.txt\nfor the source of guides, 2018-05-20) for the other guides.\n\nSigned-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n---\n Documentation/gitsubmodules.txt | 2 +-\n command-list.txt                | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt\nindex 0a890205b8..c476f891b5 100644\n--- a/Documentation/gitsubmodules.txt\n+++ b/Documentation/gitsubmodules.txt\n@@ -3,7 +3,7 @@ gitsubmodules(7)\n \n NAME\n ----\n-gitsubmodules - mounting one repository inside another\n+gitsubmodules - Mounting one repository inside another\n \n SYNOPSIS\n --------\ndiff --git a/command-list.txt b/command-list.txt\nindex a9ac72bef4..72e435c5a3 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -203,6 +203,7 @@ gitmodules                              guide\n gitnamespaces                           guide\n gitrepository-layout                    guide\n gitrevisions                            guide\n+gitsubmodules                           guide\n gittutorial-2                           guide\n gittutorial                             guide\n gitworkflows                            guide\n-- \ngitgitgadget\n"},{"id":"384988","messageId":"pull.433.git.1572267946.gitgitgadget@gmail.com","threadId":"52138","inReplyTo":null,"subject":"[PATCH 0/1] help: add gitsubmodules to the list of guides","fromName":"Philippe Blain via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-28T13:05:45Z","receivedAt":"2019-10-28T13:05:52Z","isPatch":true,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"The guide \"gitsubmodules\" was added in d480345 (submodules: overhaul\ndocumentation, 2017-06-22), but it was not added to command-list.txt when\ncommit 1b81d8c (help: use command-list.txt for the source of guides,\n2018-05-20) taught \"git help\" to obtain the guide list from this file.\n\nAdd it now.\n\nPhilippe Blain (1):\n  help: add gitsubmodules to the list of guides\n\n Documentation/gitsubmodules.txt | 2 +-\n command-list.txt                | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)\n\n\nbase-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-433%2Fphil-blain%2Fadd-gitsubmodules-to-guides-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-433/phil-blain/add-gitsubmodules-to-guides-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/433\n-- \ngitgitgadget\n"},{"id":"385017","messageId":"20191028215104.GC12487@google.com","threadId":"52138","inReplyTo":"8026c7e9ab2f60af770fa66097d3220259201d8f.1572267946.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] help: add gitsubmodules to the list of guides","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2019-10-28T21:51:04Z","receivedAt":"2019-10-28T21:51:09Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Philippe Blain wrote:\n\n> The guide \"gitsubmodules\" was added in d480345 (submodules: overhaul\n> documentation, 2017-06-22), but it was not added to\n> command-list.txt when commit 1b81d8c (help: use command-list.txt\n> for the source of guides, 2018-05-20) taught \"git help\" to obtain the\n> guide list from this file.\n>\n> Add it now, and capitalize the first word of the description of\n> gitsubmodules, as was done in 1b81d8c (help: use command-list.txt\n> for the source of guides, 2018-05-20) for the other guides.\n>\n> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>\n> ---\n>  Documentation/gitsubmodules.txt | 2 +-\n>  command-list.txt                | 1 +\n>  2 files changed, 2 insertions(+), 1 deletion(-)\n\nGood catch.  Thanks for taking care of it.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"}]}