threads / patch / 52051

patcht7519-status-fsmonitor: improve comments

Subject: [PATCH 1/1] t7519-status-fsmonitor: improve comments

## tl;dr

4 messages between Oct 16, 2019 and Oct 30, 2019. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

William Baker via GitGitGadget· Oct 16, 2019, 19:35 UTC · lore

[PATCH 0/1] t7519-status-fsmonitor: improve comments

This patch series is based on the 'wb/fsmonitor-bitmap-fix' branch and addresses feedback on the new test that was added there.

I've updated the comments for the new test to more accurately describe the scenario being tested.

Thanks,
William
William Baker (1):
  t7519-status-fsmonitor: improve comments
 t/t7519-status-fsmonitor.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
base-commit: 3444ec2eb2be58c285d2bf04f39e6e9ea5eda9a2
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-404%2Fwilbaker%2Ffsmonitor_test_cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-404/wilbaker/fsmonitor_test_cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/404
-- 
gitgitgadget
William Baker via GitGitGadget· Oct 16, 2019, 19:35 UTC · re: William Baker via GitGitGadget · lore
From: William Baker <William.Baker@microsoft.com>

The comments for the staging/unstaging test did not accurately describe the scenario being tested. It is not essential that the test files being staged/unstaged appear at the end of the index. All that is required is that the test files are not flagged with CE_FSMONITOR_VALID and have a position in the index greater than the number of entries in the index after unstaging.

The comment for this test has been updated to be more accurate with respect to the scenario that's being tested.

Signed-off-by: William Baker <William.Baker@microsoft.com>
---
 t/t7519-status-fsmonitor.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Show changes to t/t7519-status-fsmonitor.sh +5 −3
diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
index d8df990972..997d5fb349 100755
--- a/t/t7519-status-fsmonitor.sh
+++ b/t/t7519-status-fsmonitor.sh
@@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '
 	test_cmp expect actual
 '
 
-# Test staging/unstaging files that appear at the end of the index.  Test
-# file names begin with 'z' so that they are sorted to the end of the index.
-test_expect_success 'status succeeds after staging/unstaging ' '
+# Test unstaging entries that:
+#  - Are not flagged with CE_FSMONITOR_VALID
+#  - Have a position in the index >= the number of entries present in the index
+#    after unstaging.
+test_expect_success 'status succeeds after staging/unstaging' '
 	test_create_repo fsmonitor-stage-unstage &&
 	(
 		cd fsmonitor-stage-unstage &&

-- 
gitgitgadget
William Baker· Oct 29, 2019, 20:07 UTC · re: William Baker via GitGitGadget · lore

Re: [PATCH 1/1] t7519-status-fsmonitor: improve comments

On 10/16/19 12:35 PM, William Baker via GitGitGadget wrote:
Show 38 quoted lines
> From: William Baker <William.Baker@microsoft.com>
> 
> The comments for the staging/unstaging test did not accurately
> describe the scenario being tested.  It is not essential that
> the test files being staged/unstaged appear at the end of the
> index.  All that is required is that the test files are not
> flagged with CE_FSMONITOR_VALID and have a position in the
> index greater than the number of entries in the index after
> unstaging.
> 
> The comment for this test has been updated to be more
> accurate with respect to the scenario that's being tested.
> 
> Signed-off-by: William Baker <William.Baker@microsoft.com>
> ---
>  t/t7519-status-fsmonitor.sh | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
> index d8df990972..997d5fb349 100755
> --- a/t/t7519-status-fsmonitor.sh
> +++ b/t/t7519-status-fsmonitor.sh
> @@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '
>  	test_cmp expect actual
>  '
>  
> -# Test staging/unstaging files that appear at the end of the index.  Test
> -# file names begin with 'z' so that they are sorted to the end of the index.
> -test_expect_success 'status succeeds after staging/unstaging ' '
> +# Test unstaging entries that:
> +#  - Are not flagged with CE_FSMONITOR_VALID
> +#  - Have a position in the index >= the number of entries present in the index
> +#    after unstaging.
> +test_expect_success 'status succeeds after staging/unstaging' '
>  	test_create_repo fsmonitor-stage-unstage &&
>  	(
>  		cd fsmonitor-stage-unstage &&
>

Gentle ping on this patch. It's just a small update to the comments for an fsmonitor related test based on feedback I received in the segfault fix patch series [1].

Thanks, William

[1] https://public-inbox.org/git/3d3b290c-bc15-4bd5-e0c0-1377c9ec3ff9@gmail.com/
Junio C Hamano· Oct 30, 2019, 02:52 UTC · re: William Baker · lore

Re: [PATCH 1/1] t7519-status-fsmonitor: improve comments

William Baker <williamtbakeremail@gmail.com> writes:
> Gentle ping on this patch.  It's just a small update to the comments
> for an fsmonitor related test based on feedback I received in the
> segfault fix patch series [1].
Thanks for a reminder.  Queued.

← back to recent threads