{"thread":{"id":"52051","subject":"[PATCH 1/1] t7519-status-fsmonitor: improve comments","startedAt":"2019-10-16T19:35:54Z","lastAt":"2019-10-30T02:52:52Z","messageCount":4,"participants":["William Baker via GitGitGadget","William Baker","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"384206","messageId":"85ca71fadaa7390a32218d3a5553c83d60c06a7f.1571254547.git.gitgitgadget@gmail.com","threadId":"52051","inReplyTo":"pull.404.git.1571254547.gitgitgadget@gmail.com","subject":"[PATCH 1/1] t7519-status-fsmonitor: improve comments","fromName":"William Baker via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-16T19:35:47Z","receivedAt":"2019-10-16T19:35:54Z","isPatch":true,"sender":{"key":"williamtbakeremail@gmail.com","avatar":null},"body":"From: William Baker \n\nThe comments for the staging/unstaging test did not accurately\ndescribe the scenario being tested. It is not essential that\nthe test files being staged/unstaged appear at the end of the\nindex. All that is required is that the test files are not\nflagged with CE_FSMONITOR_VALID and have a position in the\nindex greater than the number of entries in the index after\nunstaging.\n\nThe comment for this test has been updated to be more\naccurate with respect to the scenario that's being tested.\n\nSigned-off-by: William Baker \n---\n t/t7519-status-fsmonitor.sh | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh\nindex d8df990972..997d5fb349 100755\n--- a/t/t7519-status-fsmonitor.sh\n+++ b/t/t7519-status-fsmonitor.sh\n@@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '\n \ttest_cmp expect actual\n '\n \n-# Test staging/unstaging files that appear at the end of the index. Test\n-# file names begin with 'z' so that they are sorted to the end of the index.\n-test_expect_success 'status succeeds after staging/unstaging ' '\n+# Test unstaging entries that:\n+# - Are not flagged with CE_FSMONITOR_VALID\n+# - Have a position in the index >= the number of entries present in the index\n+# after unstaging.\n+test_expect_success 'status succeeds after staging/unstaging' '\n \ttest_create_repo fsmonitor-stage-unstage &&\n \t(\n \t\tcd fsmonitor-stage-unstage &&\n-- \ngitgitgadget\n"},{"id":"384207","messageId":"pull.404.git.1571254547.gitgitgadget@gmail.com","threadId":"52051","inReplyTo":null,"subject":"[PATCH 0/1] t7519-status-fsmonitor: improve comments","fromName":"William Baker via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-16T19:35:46Z","receivedAt":"2019-10-16T19:36:01Z","isPatch":true,"sender":{"key":"williamtbakeremail@gmail.com","avatar":null},"body":"This patch series is based on the 'wb/fsmonitor-bitmap-fix' branch and\naddresses feedback on the new test that was added there. \n\nI've updated the comments for the new test to more accurately describe the\nscenario being tested.\n\nThanks,\n\nWilliam\n\nWilliam Baker (1):\n t7519-status-fsmonitor: improve comments\n\n t/t7519-status-fsmonitor.sh | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\n\nbase-commit: 3444ec2eb2be58c285d2bf04f39e6e9ea5eda9a2\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-404%2Fwilbaker%2Ffsmonitor_test_cleanup-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-404/wilbaker/fsmonitor_test_cleanup-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/404\n-- \ngitgitgadget\n"},{"id":"385099","messageId":"3e95662d-3c65-8511-a01b-226b0e572b83@gmail.com","threadId":"52051","inReplyTo":"85ca71fadaa7390a32218d3a5553c83d60c06a7f.1571254547.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] t7519-status-fsmonitor: improve comments","fromName":"William Baker","fromEmail":"williamtbakeremail@gmail.com","sentAt":"2019-10-29T20:07:17Z","receivedAt":"2019-10-29T20:07:22Z","isPatch":true,"sender":{"key":"williamtbakeremail@gmail.com","avatar":null},"body":"On 10/16/19 12:35 PM, William Baker via GitGitGadget wrote:\n> From: William Baker \n> \n> The comments for the staging/unstaging test did not accurately\n> describe the scenario being tested. It is not essential that\n> the test files being staged/unstaged appear at the end of the\n> index. All that is required is that the test files are not\n> flagged with CE_FSMONITOR_VALID and have a position in the\n> index greater than the number of entries in the index after\n> unstaging.\n> \n> The comment for this test has been updated to be more\n> accurate with respect to the scenario that's being tested.\n> \n> Signed-off-by: William Baker \n> ---\n> t/t7519-status-fsmonitor.sh | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh\n> index d8df990972..997d5fb349 100755\n> --- a/t/t7519-status-fsmonitor.sh\n> +++ b/t/t7519-status-fsmonitor.sh\n> @@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '\n> \ttest_cmp expect actual\n> '\n> \n> -# Test staging/unstaging files that appear at the end of the index. Test\n> -# file names begin with 'z' so that they are sorted to the end of the index.\n> -test_expect_success 'status succeeds after staging/unstaging ' '\n> +# Test unstaging entries that:\n> +# - Are not flagged with CE_FSMONITOR_VALID\n> +# - Have a position in the index >= the number of entries present in the index\n> +# after unstaging.\n> +test_expect_success 'status succeeds after staging/unstaging' '\n> \ttest_create_repo fsmonitor-stage-unstage &&\n> \t(\n> \t\tcd fsmonitor-stage-unstage &&\n> \n\nGentle ping on this patch. It's just a small update to the comments\nfor an fsmonitor related test based on feedback I received in the\nsegfault fix patch series [1].\n\nThanks,\nWilliam\n\n[1] https://public-inbox.org/git/3d3b290c-bc15-4bd5-e0c0-1377c9ec3ff9@gmail.com/\n"},{"id":"385133","messageId":"xmqq7e4n3pxc.fsf@gitster-ct.c.googlers.com","threadId":"52051","inReplyTo":"3e95662d-3c65-8511-a01b-226b0e572b83@gmail.com","subject":"Re: [PATCH 1/1] t7519-status-fsmonitor: improve comments","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-10-30T02:52:47Z","receivedAt":"2019-10-30T02:52:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"William Baker writes:\n\n> Gentle ping on this patch. It's just a small update to the comments\n> for an fsmonitor related test based on feedback I received in the\n> segfault fix patch series [1].\n\nThanks for a reminder. Queued.\n"}]}