threads / patch / 5110

patchRe: [PATCH] fix git-revert command-line options

Subject: Re: [PATCH] fix git-revert command-line options

## tl;dr

3 messages between Aug 3, 2006 and Aug 3, 2006. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Martin Waitz· Aug 3, 2006, 18:41 UTC · lore

hoi :)

On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:

> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> +	-n|--no-c|--no-co|--no-com|--no-comm|\

> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> +	--n|--no-e|--no-ed|--no-edi|--no-edit)

well spottet, but now we still have "-n" versus "--n". Perhaps we should drop the single-letter options or at least only keep one of them and then explicitly document that in the manpage.

-- 
Martin Waitz

Junio C Hamano· Aug 3, 2006, 19:31 UTC · re: Martin Waitz · lore

Martin Waitz <tali@admingilde.org> writes:

Show 10 quoted lines

> On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
>> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
>> +	-n|--no-c|--no-co|--no-com|--no-comm|\
>
>> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
>> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
>
> well spottet, but now we still have "-n" versus "--n".
> Perhaps we should drop the single-letter options or at least only
> keep one of them and then explicitly document that in the manpage.

Good suggestion.

Michael· Aug 3, 2006, 20:48 UTC · re: Junio C Hamano · lore

Junio C Hamano wrote:

Show 13 quoted lines

> Martin Waitz <tali@admingilde.org> writes:
> > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> >> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> >> +	-n|--no-c|--no-co|--no-com|--no-comm|\
> >>
> >> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> >> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
> >
> > well spottet, but now we still have "-n" versus "--n".
> > Perhaps we should drop the single-letter options or at least only
> > keep one of them and then explicitly document that in the manpage.
>
> Good suggestion.

Well, I left "--n" for the lazy typers, but it's too confusing - and can be easy misremembered. I'd leave "-n" for "--no-commit", though (and it's already on man page). Your choice.