# Re: [PATCH] fix git-revert command-line options

3 messages from 2006-08-03 to 2006-08-03. Participants: Martin Waitz, Junio C Hamano, Michael.
Thread: https://gitlist.dev/t/5110

## Martin Waitz, 2006-08-03 18:41

Subject: Re: [PATCH] fix git-revert command-line options
Message-ID: <20060803184141.GA5476@admingilde.org>
URL: https://gitlist.dev/e/20060803184141.GA5476%40admingilde.org
In-Reply-To: <20060803153742.109978@dial-up-mi-12.lombardiacom.it>

```
hoi :)

On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> +	-n|--no-c|--no-co|--no-com|--no-comm|\

> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> +	--n|--no-e|--no-ed|--no-edi|--no-edit)

well spottet, but now we still have "-n" versus "--n".
Perhaps we should drop the single-letter options or at least only
keep one of them and then explicitly document that in the manpage.

-- 
Martin Waitz

```

## Junio C Hamano, 2006-08-03 19:31

Subject: Re: [PATCH] fix git-revert command-line options
Message-ID: <7vmzalpqdt.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vmzalpqdt.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20060803184141.GA5476@admingilde.org>

```
Martin Waitz <tali@admingilde.org> writes:

> On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
>> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
>> +	-n|--no-c|--no-co|--no-com|--no-comm|\
>
>> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
>> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
>
> well spottet, but now we still have "-n" versus "--n".
> Perhaps we should drop the single-letter options or at least only
> keep one of them and then explicitly document that in the manpage.

Good suggestion.

```

## Michael, 2006-08-03 20:48

Subject: Re: [PATCH] fix git-revert command-line options
Message-ID: <200608032248.58156.barra_cuda@katamail.com>
URL: https://gitlist.dev/e/200608032248.58156.barra_cuda%40katamail.com
In-Reply-To: <7vmzalpqdt.fsf@assigned-by-dhcp.cox.net>

```
Junio C Hamano wrote:
> Martin Waitz <tali@admingilde.org> writes:
> > On Thu, Aug 03, 2006 at 05:42:23PM +0200, Michael wrote:
> >> -	-n|--n|--no|--no-|--no-c|--no-co|--no-com|--no-comm|\
> >> +	-n|--no-c|--no-co|--no-com|--no-comm|\
> >>
> >> -	--n|--no|--no-|--no-e|--no-ed|--no-edi|--no-edit)
> >> +	--n|--no-e|--no-ed|--no-edi|--no-edit)
> >
> > well spottet, but now we still have "-n" versus "--n".
> > Perhaps we should drop the single-letter options or at least only
> > keep one of them and then explicitly document that in the manpage.
>
> Good suggestion.

Well, I left "--n" for the lazy typers, but it's too confusing - and
can be easy misremembered. I'd leave "-n" for "--no-commit", though
(and it's already on man page).
Your choice.

```