threads / patch / 51055

patchDoc: add missing backticks to pull.rebase value

Subject: [PATCH] Doc: add missing backticks to pull.rebase value

## tl;dr

2 messages between May 8, 2019 and May 8, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Denton Liu· May 8, 2019, 18:43 UTC · lore

In the documentation for pull.rebase, all of the valid values are surrounded with backticks except for "true". Surround "true" with these missing backticks.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 Documentation/config/pull.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/config/pull.txt +1 −1

diff --git a/Documentation/config/pull.txt b/Documentation/config/pull.txt
index b87cab31b3..6cdb2f320d 100644
--- a/Documentation/config/pull.txt
+++ b/Documentation/config/pull.txt
@@ -9,7 +9,7 @@ pull.ff::
 	command line). This setting overrides `merge.ff` when pulling.
 
 pull.rebase::
-	When true, rebase branches on top of the fetched branch, instead
+	When `true`, rebase branches on top of the fetched branch, instead
 	of merging the default branch from the default remote when "git
 	pull" is run. See "branch.<name>.rebase" for setting this on a
 	per-branch basis.

-- 
2.21.0.1049.geb646f7864

Derrick Stolee· May 8, 2019, 19:23 UTC · re: Denton Liu · lore

Re: [PATCH] Doc: add missing backticks to pull.rebase value

On 5/8/2019 2:43 PM, Denton Liu wrote:

> In the documentation for pull.rebase, all of the valid values are
> surrounded with backticks except for "true". Surround "true" with these
> missing backticks.

This would make the rendered docs [1] look a bit better, but I think this series is incomplete. Looking just a little bit further down in the 'push' config options, I see more with this same problem [2].

While you are here, could you track down the other similar issues?

Thanks, -Stolee

[1] https://git-scm.com/docs/git-config#Documentation/git-config.txt-pullrebase

[2] https://github.com/git/git/blob/master/Documentation/config/push.txt#L59