{"thread":{"id":"51055","subject":"[PATCH] Doc: add missing backticks to pull.rebase value","startedAt":"2019-05-08T18:43:49Z","lastAt":"2019-05-08T19:23:08Z","messageCount":2,"participants":["Denton Liu","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"375176","messageId":"0e185c7c4b7ecb20631e1d330ce70ecf78427621.1557340984.git.liu.denton@gmail.com","threadId":"51055","inReplyTo":null,"subject":"[PATCH] Doc: add missing backticks to pull.rebase value","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-05-08T18:43:43Z","receivedAt":"2019-05-08T18:43:49Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"In the documentation for pull.rebase, all of the valid values are\nsurrounded with backticks except for \"true\". Surround \"true\" with these\nmissing backticks.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n Documentation/config/pull.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/pull.txt b/Documentation/config/pull.txt\nindex b87cab31b3..6cdb2f320d 100644\n--- a/Documentation/config/pull.txt\n+++ b/Documentation/config/pull.txt\n@@ -9,7 +9,7 @@ pull.ff::\n \tcommand line). This setting overrides `merge.ff` when pulling.\n \n pull.rebase::\n-\tWhen true, rebase branches on top of the fetched branch, instead\n+\tWhen `true`, rebase branches on top of the fetched branch, instead\n \tof merging the default branch from the default remote when \"git\n \tpull\" is run. See \"branch.<name>.rebase\" for setting this on a\n \tper-branch basis.\n-- \n2.21.0.1049.geb646f7864\n\n"},{"id":"375180","messageId":"aa4e4eef-01f2-5d64-afbf-eec41cefe15f@gmail.com","threadId":"51055","inReplyTo":"0e185c7c4b7ecb20631e1d330ce70ecf78427621.1557340984.git.liu.denton@gmail.com","subject":"Re: [PATCH] Doc: add missing backticks to pull.rebase value","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2019-05-08T19:23:04Z","receivedAt":"2019-05-08T19:23:08Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 5/8/2019 2:43 PM, Denton Liu wrote:\n> In the documentation for pull.rebase, all of the valid values are\n> surrounded with backticks except for \"true\". Surround \"true\" with these\n> missing backticks.\n\nThis would make the rendered docs [1] look a bit better, but I think this series\nis incomplete. Looking just a little bit further down in the 'push' config options,\nI see more with this same problem [2].\n\nWhile you are here, could you track down the other similar issues?\n\nThanks,\n-Stolee\n\n[1] https://git-scm.com/docs/git-config#Documentation/git-config.txt-pullrebase\n\n[2] https://github.com/git/git/blob/master/Documentation/config/push.txt#L59\n"}]}