threads / patch / 51049

patcht/lib-httpd: pass LSAN_OPTIONS through apache

Subject: [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache

## tl;dr

2 messages between May 7, 2019 and May 7, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jeff King· May 7, 2019, 22:30 UTC · lore

Just as we instruct Apache to pass through ASAN_OPTIONS (so that server-side Git programs it spawns will respect our options while running the tests), we should do the same with LSAN_OPTIONS. Otherwise trying to collect a list of leaks like:

    export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan
    make SANITIZE=leak test

won't work for http tests (the server-side programs won't log their leaks to the right place, and they'll prematurely die, producing a spurious test failure).

Signed-off-by: Jeff King <peff@peff.net>
---
Found this after giving similar advice in

  https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/

 t/lib-httpd/apache.conf | 1 +
 1 file changed, 1 insertion(+)

Show changes to t/lib-httpd/apache.conf +1 −0

diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
index 06a81b54c7..5c1c86c193 100644
--- a/t/lib-httpd/apache.conf
+++ b/t/lib-httpd/apache.conf
@@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND
 PassEnv GIT_VALGRIND_OPTIONS
 PassEnv GNUPGHOME
 PassEnv ASAN_OPTIONS
+PassEnv LSAN_OPTIONS
 PassEnv GIT_TRACE
 PassEnv GIT_CONFIG_NOSYSTEM
 PassEnv GIT_TEST_SIDEBAND_ALL

-- 
2.21.0.1314.g224b191707

Josh Steadmon· May 7, 2019, 22:45 UTC · re: Jeff King · lore

Re: [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache

On 2019.05.07 18:30, Jeff King wrote:

Show 35 quoted lines

> Just as we instruct Apache to pass through ASAN_OPTIONS (so that
> server-side Git programs it spawns will respect our options while
> running the tests), we should do the same with LSAN_OPTIONS. Otherwise
> trying to collect a list of leaks like:
> 
>     export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan
>     make SANITIZE=leak test
> 
> won't work for http tests (the server-side programs won't log their
> leaks to the right place, and they'll prematurely die, producing a
> spurious test failure).
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Found this after giving similar advice in
> 
>   https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/
> 
>  t/lib-httpd/apache.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
> index 06a81b54c7..5c1c86c193 100644
> --- a/t/lib-httpd/apache.conf
> +++ b/t/lib-httpd/apache.conf
> @@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND
>  PassEnv GIT_VALGRIND_OPTIONS
>  PassEnv GNUPGHOME
>  PassEnv ASAN_OPTIONS
> +PassEnv LSAN_OPTIONS
>  PassEnv GIT_TRACE
>  PassEnv GIT_CONFIG_NOSYSTEM
>  PassEnv GIT_TEST_SIDEBAND_ALL
> -- 
> 2.21.0.1314.g224b191707

Looks good to me.