{"thread":{"id":"51049","subject":"[PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache","startedAt":"2019-05-07T22:30:50Z","lastAt":"2019-05-07T22:45:30Z","messageCount":2,"participants":["Jeff King","Josh Steadmon"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"375064","messageId":"20190507223046.GA16315@sigill.intra.peff.net","threadId":"51049","inReplyTo":null,"subject":"[PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-05-07T22:30:46Z","receivedAt":"2019-05-07T22:30:50Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Just as we instruct Apache to pass through ASAN_OPTIONS (so that\nserver-side Git programs it spawns will respect our options while\nrunning the tests), we should do the same with LSAN_OPTIONS. Otherwise\ntrying to collect a list of leaks like:\n\n    export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan\n    make SANITIZE=leak test\n\nwon't work for http tests (the server-side programs won't log their\nleaks to the right place, and they'll prematurely die, producing a\nspurious test failure).\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nFound this after giving similar advice in\n\n  https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/\n\n t/lib-httpd/apache.conf | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf\nindex 06a81b54c7..5c1c86c193 100644\n--- a/t/lib-httpd/apache.conf\n+++ b/t/lib-httpd/apache.conf\n@@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND\n PassEnv GIT_VALGRIND_OPTIONS\n PassEnv GNUPGHOME\n PassEnv ASAN_OPTIONS\n+PassEnv LSAN_OPTIONS\n PassEnv GIT_TRACE\n PassEnv GIT_CONFIG_NOSYSTEM\n PassEnv GIT_TEST_SIDEBAND_ALL\n-- \n2.21.0.1314.g224b191707\n"},{"id":"375065","messageId":"20190507224520.GD26779@google.com","threadId":"51049","inReplyTo":"20190507223046.GA16315@sigill.intra.peff.net","subject":"Re: [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2019-05-07T22:45:20Z","receivedAt":"2019-05-07T22:45:30Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"On 2019.05.07 18:30, Jeff King wrote:\n> Just as we instruct Apache to pass through ASAN_OPTIONS (so that\n> server-side Git programs it spawns will respect our options while\n> running the tests), we should do the same with LSAN_OPTIONS. Otherwise\n> trying to collect a list of leaks like:\n> \n>     export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan\n>     make SANITIZE=leak test\n> \n> won't work for http tests (the server-side programs won't log their\n> leaks to the right place, and they'll prematurely die, producing a\n> spurious test failure).\n> \n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> Found this after giving similar advice in\n> \n>   https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/\n> \n>  t/lib-httpd/apache.conf | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf\n> index 06a81b54c7..5c1c86c193 100644\n> --- a/t/lib-httpd/apache.conf\n> +++ b/t/lib-httpd/apache.conf\n> @@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND\n>  PassEnv GIT_VALGRIND_OPTIONS\n>  PassEnv GNUPGHOME\n>  PassEnv ASAN_OPTIONS\n> +PassEnv LSAN_OPTIONS\n>  PassEnv GIT_TRACE\n>  PassEnv GIT_CONFIG_NOSYSTEM\n>  PassEnv GIT_TEST_SIDEBAND_ALL\n> -- \n> 2.21.0.1314.g224b191707\n\nLooks good to me.\n"}]}