threads / bug / 50885

Bug: subcommand autocomplete fails on 2.21.0

Subject: Bug: subcommand autocomplete fails on 2.21.0

## tl;dr

3 messages between Apr 6, 2019 and Apr 6, 2019.

replies: 2people: 2as markdown or json

Paul Schreiber· Apr 6, 2019, 16:36 UTC · lore

With git 2.21.0, tab completion no longer works for subcommands.

STEPS TO REPRODUCE
1. install git 2.21.0 from https://git-scm.com/download/mac
2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
2. git clone https://github.com/tj/git-extras
3. cd git-extras
4. sudo make install
5. change directory to a git repository
6. type "git del” and press [tab]

EXPECTED line is changed to "git delete-merged-branches"

ACTUAL [beep]

CONFIG macOS 10.13.6 (17G5019) and macOS 10.14 (18E226) git 2.21.0 git-extras 4.8.0-dev

REGRESSION Works as expected with git 2.17.0.

Paul

SZEDER Gábor· Apr 6, 2019, 17:49 UTC · re: Paul Schreiber · lore

Re: Bug: subcommand autocomplete fails on 2.21.0

On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:

Show 8 quoted lines

> With git 2.21.0, tab completion no longer works for subcommands.
> 
> STEPS TO REPRODUCE
> 1. install git 2.21.0 from https://git-scm.com/download/mac
> 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
> 2. git clone https://github.com/tj/git-extras
> 3. cd git-extras
> 4. sudo make install

By the looks of it, this installs five commands whose names start with 'del':

  git-delete-branch
  git-delete-merged-branches
  git-delete-submodule
  git-delete-tag
  git-delta

If this is indeed the case, then ...

Show 5 quoted lines

> 5. change directory to a git repository
> 6. type "git del” and press [tab] 
> 
> EXPECTED
> line is changed to "git delete-merged-branches"

... this behavior would, in fact, be a bug, because 'del' is the unique prefix of those five commands.

> ACTUAL
> [beep]

And I think this is the right behavior, and on a second TAB it should list all commands whose name starts with 'del'.

Show 7 quoted lines

> CONFIG
> macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
> git 2.21.0
> git-extras 4.8.0-dev
> 
> REGRESSION
> Works as expected with git 2.17.0.

SZEDER Gábor· Apr 6, 2019, 21:19 UTC · re: SZEDER Gábor · lore

Re: Bug: subcommand autocomplete fails on 2.21.0

On Sat, Apr 06, 2019 at 07:49:29PM +0200, SZEDER Gábor wrote:

Show 29 quoted lines

> On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:
> > With git 2.21.0, tab completion no longer works for subcommands.
> > 
> > STEPS TO REPRODUCE
> > 1. install git 2.21.0 from https://git-scm.com/download/mac
> > 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
> > 2. git clone https://github.com/tj/git-extras
> > 3. cd git-extras
> > 4. sudo make install
> 
> By the looks of it, this installs five commands whose names start with
> 'del':
> 
>   git-delete-branch
>   git-delete-merged-branches
>   git-delete-submodule
>   git-delete-tag
>   git-delta
> 
> If this is indeed the case, then ...
> 
> > 5. change directory to a git repository
> > 6. type "git del” and press [tab] 
> > 
> > EXPECTED
> > line is changed to "git delete-merged-branches"
> 
> ... this behavior would, in fact, be a bug, because 'del' is the
> unique prefix of those five commands.

Erm, let me rephrase, because this doesn't make sense:

... this behavior would, in fact, be a bug, because 'del' is the common prefix of those five commands, so it can't be uniquely completed.

Show 14 quoted lines

> > ACTUAL
> > [beep]
> 
> And I think this is the right behavior, and on a second TAB it should
> list all commands whose name starts with 'del'.
> 
> > CONFIG
> > macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
> > git 2.21.0
> > git-extras 4.8.0-dev
> > 
> > REGRESSION
> > Works as expected with git 2.17.0.
>