{"thread":{"id":"50885","subject":"Bug: subcommand autocomplete fails on 2.21.0","startedAt":"2019-04-06T16:36:34Z","lastAt":"2019-04-06T21:23:35Z","messageCount":3,"participants":["Paul Schreiber","SZEDER Gábor"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"373329","messageId":"E4A677E6-E624-464B-9BC6-AAAE0A77EFFE@gmail.com","threadId":"50885","inReplyTo":null,"subject":"Bug: subcommand autocomplete fails on 2.21.0","fromName":"Paul Schreiber","fromEmail":"paulschreiber@gmail.com","sentAt":"2019-04-06T16:36:30Z","receivedAt":"2019-04-06T16:36:34Z","isPatch":false,"sender":{"key":"paulschreiber@gmail.com","avatar":null},"body":"With git 2.21.0, tab completion no longer works for subcommands.\n\nSTEPS TO REPRODUCE\n1. install git 2.21.0 from https://git-scm.com/download/mac\n2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)\n2. git clone https://github.com/tj/git-extras\n3. cd git-extras\n4. sudo make install\n5. change directory to a git repository\n6. type \"git del” and press [tab] \n\nEXPECTED\nline is changed to \"git delete-merged-branches\"\n\nACTUAL\n[beep]\n\nCONFIG\nmacOS 10.13.6 (17G5019) and macOS 10.14 (18E226)\ngit 2.21.0\ngit-extras 4.8.0-dev\n\nREGRESSION\nWorks as expected with git 2.17.0.\n\n\n\nPaul"},{"id":"373331","messageId":"20190406174929.GD8796@szeder.dev","threadId":"50885","inReplyTo":"E4A677E6-E624-464B-9BC6-AAAE0A77EFFE@gmail.com","subject":"Re: Bug: subcommand autocomplete fails on 2.21.0","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-04-06T17:49:29Z","receivedAt":"2019-04-06T17:49:35Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:\n> With git 2.21.0, tab completion no longer works for subcommands.\n> \n> STEPS TO REPRODUCE\n> 1. install git 2.21.0 from https://git-scm.com/download/mac\n> 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)\n> 2. git clone https://github.com/tj/git-extras\n> 3. cd git-extras\n> 4. sudo make install\n\nBy the looks of it, this installs five commands whose names start with\n'del':\n\n  git-delete-branch\n  git-delete-merged-branches\n  git-delete-submodule\n  git-delete-tag\n  git-delta\n\nIf this is indeed the case, then ...\n\n> 5. change directory to a git repository\n> 6. type \"git del” and press [tab] \n> \n> EXPECTED\n> line is changed to \"git delete-merged-branches\"\n\n... this behavior would, in fact, be a bug, because 'del' is the\nunique prefix of those five commands.\n\n> ACTUAL\n> [beep]\n\nAnd I think this is the right behavior, and on a second TAB it should\nlist all commands whose name starts with 'del'.\n\n> CONFIG\n> macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)\n> git 2.21.0\n> git-extras 4.8.0-dev\n> \n> REGRESSION\n> Works as expected with git 2.17.0.\n\n"},{"id":"373340","messageId":"20190406211958.GE8796@szeder.dev","threadId":"50885","inReplyTo":"20190406174929.GD8796@szeder.dev","subject":"Re: Bug: subcommand autocomplete fails on 2.21.0","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-04-06T21:19:58Z","receivedAt":"2019-04-06T21:23:35Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Sat, Apr 06, 2019 at 07:49:29PM +0200, SZEDER Gábor wrote:\n> On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:\n> > With git 2.21.0, tab completion no longer works for subcommands.\n> > \n> > STEPS TO REPRODUCE\n> > 1. install git 2.21.0 from https://git-scm.com/download/mac\n> > 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)\n> > 2. git clone https://github.com/tj/git-extras\n> > 3. cd git-extras\n> > 4. sudo make install\n> \n> By the looks of it, this installs five commands whose names start with\n> 'del':\n> \n>   git-delete-branch\n>   git-delete-merged-branches\n>   git-delete-submodule\n>   git-delete-tag\n>   git-delta\n> \n> If this is indeed the case, then ...\n> \n> > 5. change directory to a git repository\n> > 6. type \"git del” and press [tab] \n> > \n> > EXPECTED\n> > line is changed to \"git delete-merged-branches\"\n> \n> ... this behavior would, in fact, be a bug, because 'del' is the\n> unique prefix of those five commands.\n\nErm, let me rephrase, because this doesn't make sense:\n\n... this behavior would, in fact, be a bug, because 'del' is the\ncommon prefix of those five commands, so it can't be uniquely\ncompleted.\n\n> > ACTUAL\n> > [beep]\n> \n> And I think this is the right behavior, and on a second TAB it should\n> list all commands whose name starts with 'del'.\n> \n> > CONFIG\n> > macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)\n> > git 2.21.0\n> > git-extras 4.8.0-dev\n> > \n> > REGRESSION\n> > Works as expected with git 2.17.0.\n> \n"}]}