[PATCH] promisor-remote.h: fix a 'hdr-check' warning

Ramsay Jones· Mar 13, 2019, 19:03 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Christian,

If you need to re-roll your 'cc/multi-promisor' branch, could you please squash this into the relevant patch (commit 9e8a7cf4be ("promisor-remote: implement promisor_remote_get_direct()", 2019-03-12)).

Also, I note that the promisor_remote_new() function is not called outside of 'promisor-remote.c' and so could be a file-local symbol. Are there any plans for future calls to this function (outside of this file)? If not, could you please mark this function as static and remove the extern declaration.

Thanks!

ATB, Ramsay Jones

 promisor-remote.h | 2 ++
 1 file changed, 2 insertions(+)

Show changes to promisor-remote.h +2 −0

diff --git a/promisor-remote.h b/promisor-remote.h
index f0d609a3f5..d90df11996 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
 #ifndef PROMISOR_REMOTE_H
 #define PROMISOR_REMOTE_H
 
+struct object_id;
+
 /*
  * Promisor remote linked list
  *

-- 
2.21.0

patchpromisor-remote.h: fix a 'hdr-check' warning