{"thread":{"id":"50733","subject":"[PATCH] promisor-remote.h: fix a 'hdr-check' warning","startedAt":"2019-03-13T19:03:35Z","lastAt":"2019-03-13T19:03:35Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"371389","messageId":"88fdcc85-559a-7213-2da8-d4e641ce979a@ramsayjones.plus.com","threadId":"50733","inReplyTo":null,"subject":"[PATCH] promisor-remote.h: fix a 'hdr-check' warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-03-13T19:03:25Z","receivedAt":"2019-03-13T19:03:35Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Christian,\n\nIf you need to re-roll your 'cc/multi-promisor' branch, could you\nplease squash this into the relevant patch (commit 9e8a7cf4be\n(\"promisor-remote: implement promisor_remote_get_direct()\", 2019-03-12)).\n\nAlso, I note that the promisor_remote_new() function is not called\noutside of 'promisor-remote.c' and so could be a file-local symbol.\nAre there any plans for future calls to this function (outside of\nthis file)? If not, could you please mark this function as static\nand remove the extern declaration.\n\nThanks!\n\nATB,\nRamsay Jones\n\n promisor-remote.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/promisor-remote.h b/promisor-remote.h\nindex f0d609a3f5..d90df11996 100644\n--- a/promisor-remote.h\n+++ b/promisor-remote.h\n@@ -1,6 +1,8 @@\n #ifndef PROMISOR_REMOTE_H\n #define PROMISOR_REMOTE_H\n \n+struct object_id;\n+\n /*\n  * Promisor remote linked list\n  *\n-- \n2.21.0\n"}]}