[PATCH] sequencer: mark a file-local symbol as static

Ramsay Jones· Mar 12, 2019, 02:53 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Denton,

If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch, could you please squash this into the relevant patch (commit 9bcdf520cb ("sequencer.c: define get_config_from_cleanup", 2019-03-10)).

I note also, that the get_config_from_cleanup() function is not called outside of sequencer.c, so that this function could also be marked static (and remove the extern declaration from the header file) if there are no plans for future callers.

Thanks!

ATB, Ramsay Jones

 sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to sequencer.c +1 −1

diff --git a/sequencer.c b/sequencer.c
index 19d1279fa8..833017eb2d 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -166,7 +166,7 @@ struct cleanup_config_mapping {
 };
 
 /* note that we assume that cleanup_config_mapping[0] contains the default settings */
-struct cleanup_config_mapping cleanup_config_mappings[] = {
+static struct cleanup_config_mapping cleanup_config_mappings[] = {
 	{ "default", COMMIT_MSG_CLEANUP_ALL, COMMIT_MSG_CLEANUP_SPACE },
 	{ "verbatim", COMMIT_MSG_CLEANUP_NONE, COMMIT_MSG_CLEANUP_NONE },
 	{ "whitespace", COMMIT_MSG_CLEANUP_SPACE, COMMIT_MSG_CLEANUP_SPACE },

-- 
2.21.0

Eric Sunshine· Mar 12, 2019, 02:58 UTC · re: Ramsay Jones · lore

Re: [PATCH] sequencer: mark a file-local symbol as static

On Mon, Mar 11, 2019 at 10:53 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 7 quoted lines

> If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
> could you please squash this into the relevant patch (commit 9bcdf520cb
> ("sequencer.c: define get_config_from_cleanup", 2019-03-10)).
>
>  /* note that we assume that cleanup_config_mapping[0] contains the default settings */
> -struct cleanup_config_mapping cleanup_config_mappings[] = {
> +static struct cleanup_config_mapping cleanup_config_mappings[] = {

This was also suggested during review[1].

[1]: http://public-inbox.org/git/CAPig+cQGvmi-237s1Leb1NpOMA0683PkCG4HBCKn_+x5YDHnCQ@mail.gmail.com/

patchsequencer: mark a file-local symbol as static