{"thread":{"id":"50714","subject":"[PATCH] sequencer: mark a file-local symbol as static","startedAt":"2019-03-12T02:53:49Z","lastAt":"2019-03-12T02:58:47Z","messageCount":2,"participants":["Ramsay Jones","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"371215","messageId":"d5d47b6b-25d9-a649-e13d-76e98e07ed51@ramsayjones.plus.com","threadId":"50714","inReplyTo":null,"subject":"[PATCH] sequencer: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-03-12T02:53:46Z","receivedAt":"2019-03-12T02:53:49Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Denton,\n\nIf you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,\ncould you please squash this into the relevant patch (commit 9bcdf520cb\n(\"sequencer.c: define get_config_from_cleanup\", 2019-03-10)).\n\nI note also, that the get_config_from_cleanup() function is not\ncalled outside of sequencer.c, so that this function could also\nbe marked static (and remove the extern declaration from the\nheader file) if there are no plans for future callers.\n\nThanks!\n\nATB,\nRamsay Jones\n\n\n sequencer.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex 19d1279fa8..833017eb2d 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -166,7 +166,7 @@ struct cleanup_config_mapping {\n };\n \n /* note that we assume that cleanup_config_mapping[0] contains the default settings */\n-struct cleanup_config_mapping cleanup_config_mappings[] = {\n+static struct cleanup_config_mapping cleanup_config_mappings[] = {\n \t{ \"default\", COMMIT_MSG_CLEANUP_ALL, COMMIT_MSG_CLEANUP_SPACE },\n \t{ \"verbatim\", COMMIT_MSG_CLEANUP_NONE, COMMIT_MSG_CLEANUP_NONE },\n \t{ \"whitespace\", COMMIT_MSG_CLEANUP_SPACE, COMMIT_MSG_CLEANUP_SPACE },\n-- \n2.21.0\n"},{"id":"371216","messageId":"CAPig+cTqdeVXyYZarGOb+AiLOERO0HpK+ykYgrAddyFzPG0+Mg@mail.gmail.com","threadId":"50714","inReplyTo":"d5d47b6b-25d9-a649-e13d-76e98e07ed51@ramsayjones.plus.com","subject":"Re: [PATCH] sequencer: mark a file-local symbol as static","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2019-03-12T02:58:32Z","receivedAt":"2019-03-12T02:58:47Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Mar 11, 2019 at 10:53 PM Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n> If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,\n> could you please squash this into the relevant patch (commit 9bcdf520cb\n> (\"sequencer.c: define get_config_from_cleanup\", 2019-03-10)).\n>\n>  /* note that we assume that cleanup_config_mapping[0] contains the default settings */\n> -struct cleanup_config_mapping cleanup_config_mappings[] = {\n> +static struct cleanup_config_mapping cleanup_config_mappings[] = {\n\nThis was also suggested during review[1].\n\n[1]: http://public-inbox.org/git/CAPig+cQGvmi-237s1Leb1NpOMA0683PkCG4HBCKn_+x5YDHnCQ@mail.gmail.com/\n"}]}