threads / patch / 50613

patchRe: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)

Subject: Re: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)

## tl;dr

One message between Feb 28, 2019 and Feb 28, 2019. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Rohit Ashiwal· Feb 28, 2019, 10:36 UTC · lore
Hey Duy
Show 12 quoted lines
>
> On the Git mailing list, Duy Nguyen wrote (reply to this):
>
> I was a bit worried that the "test ! something" could be incorrectly
> converted because for example, "test ! -d foo" is not always the same
> as "test_path_is_missing". If "foo" is intended to be a file, then the
> conversion is wrong.
>
> But I don't think you made any wrong conversion here. All these
> negative "test" are preceded by "git rm" so the expectation is always
> "test ! -e".
>

Sorry for the late reply. Yes, I thought about it earlier and made changes thinking this only. Also when I was going through the code again, I replaced other conditionals `[ -f ]` with test_path_is_file etc.

Ciao Rohit

← back to recent threads