{"thread":{"id":"50613","subject":"Re: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)","startedAt":"2019-02-28T10:37:42Z","lastAt":"2019-02-28T10:37:42Z","messageCount":1,"participants":["Rohit Ashiwal"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"370361","messageId":"CAL7ArXp2VWmYmKZ2io8aV_gwMKYPsjeB+5aijbHTPxSfrYTYnA@mail.gmail.com","threadId":"50613","inReplyTo":"gitgitgadget/git/pull/152/review/208437870@github.com","subject":"Re: [gitgitgadget/git] [GSoC][PATCH] t3600: `use test_path_is_*` helper functions (#152)","fromName":"Rohit Ashiwal","fromEmail":"rohit.ashiwal265@gmail.com","sentAt":"2019-02-28T10:36:38Z","receivedAt":"2019-02-28T10:37:42Z","isPatch":true,"sender":{"key":"rohit.ashiwal265@gmail.com","avatar":"https://avatars.githubusercontent.com/u/31043830?v=4"},"body":"Hey Duy\n\n>\n> On the Git mailing list, Duy Nguyen wrote (reply to this):\n>\n> I was a bit worried that the \"test ! something\" could be incorrectly\n> converted because for example, \"test ! -d foo\" is not always the same\n> as \"test_path_is_missing\". If \"foo\" is intended to be a file, then the\n> conversion is wrong.\n>\n> But I don't think you made any wrong conversion here. All these\n> negative \"test\" are preceded by \"git rm\" so the expectation is always\n> \"test ! -e\".\n>\n\nSorry for the late reply. Yes, I thought about it earlier and made\nchanges thinking this only. Also when I was going through the code\nagain, I replaced other conditionals `[ -f ]` with test_path_is_file\netc.\n\nCiao\nRohit\n"}]}