threads / patch / 50401

v2, 2 partsconfig.mak.uname: remove obsolete SPARSE_FLAGS setting

Subject: [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting

## tl;dr

2 messages between Feb 5, 2019 and Feb 5, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Feb 5, 2019, 02:25 UTC · lore

An upcoming commit will change the semantics of the SPARSE_FLAGS variable from an internal to a user only customisation variable. The MinGW configuration section contains an obsolete setting for this variable which was used (some years ago) to cater to an error in the Win32 system header files. Since 'sparse' does not currently support the MinGW platform, nobody on that platform can be relying on this setting today. Remove this use of the SPARSE_FLAGS variable.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)

Show changes to config.mak.uname +0 −1

diff --git a/config.mak.uname b/config.mak.uname
index 7b36a1dfe7..786bb2f913 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
 	RC = windres -O coff
 	NATIVE_CRLF = YesPlease
 	X = .exe
-	SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
 ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
 	htmldir = doc/git/html/
 	prefix =

-- 
2.20.0

Johannes Schindelin· Feb 5, 2019, 11:26 UTC · re: Ramsay Jones · lore

Re: [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting

Hi Ramsay,

On Tue, 5 Feb 2019, Ramsay Jones wrote:

Show 8 quoted lines

> 
> An upcoming commit will change the semantics of the SPARSE_FLAGS
> variable from an internal to a user only customisation variable.
> The MinGW configuration section contains an obsolete setting for
> this variable which was used (some years ago) to cater to an error
> in the Win32 system header files. Since 'sparse' does not currently
> support the MinGW platform, nobody on that platform can be relying
> on this setting today. Remove this use of the SPARSE_FLAGS variable.

ACK, Dscho

Show 21 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  config.mak.uname | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/config.mak.uname b/config.mak.uname
> index 7b36a1dfe7..786bb2f913 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
>  	RC = windres -O coff
>  	NATIVE_CRLF = YesPlease
>  	X = .exe
> -	SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
>  ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
>  	htmldir = doc/git/html/
>  	prefix =
> -- 
> 2.20.0
>