# [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting 2 messages from 2019-02-05 to 2019-02-05. Participants: Ramsay Jones, Johannes Schindelin. Thread: https://gitlist.dev/t/50401 ## Ramsay Jones, 2019-02-05 02:25 Subject: [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting Message-ID: <41d4bf8a-dea9-5ccd-9fad-e4604017661d@ramsayjones.plus.com> URL: https://gitlist.dev/e/41d4bf8a-dea9-5ccd-9fad-e4604017661d%40ramsayjones.plus.com ``` An upcoming commit will change the semantics of the SPARSE_FLAGS variable from an internal to a user only customisation variable. The MinGW configuration section contains an obsolete setting for this variable which was used (some years ago) to cater to an error in the Win32 system header files. Since 'sparse' does not currently support the MinGW platform, nobody on that platform can be relying on this setting today. Remove this use of the SPARSE_FLAGS variable. Signed-off-by: Ramsay Jones --- config.mak.uname | 1 - 1 file changed, 1 deletion(-) diff --git a/config.mak.uname b/config.mak.uname index 7b36a1dfe7..786bb2f913 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S))) RC = windres -O coff NATIVE_CRLF = YesPlease X = .exe - SPARSE_FLAGS = -Wno-one-bit-signed-bitfield ifneq (,$(wildcard ../THIS_IS_MSYSGIT)) htmldir = doc/git/html/ prefix = -- 2.20.0 ``` ## Johannes Schindelin, 2019-02-05 11:26 Subject: Re: [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1902051226130.41%40tvgsbejvaqbjf.bet In-Reply-To: <41d4bf8a-dea9-5ccd-9fad-e4604017661d@ramsayjones.plus.com> ``` Hi Ramsay, On Tue, 5 Feb 2019, Ramsay Jones wrote: > > An upcoming commit will change the semantics of the SPARSE_FLAGS > variable from an internal to a user only customisation variable. > The MinGW configuration section contains an obsolete setting for > this variable which was used (some years ago) to cater to an error > in the Win32 system header files. Since 'sparse' does not currently > support the MinGW platform, nobody on that platform can be relying > on this setting today. Remove this use of the SPARSE_FLAGS variable. ACK, Dscho > > Signed-off-by: Ramsay Jones > --- > config.mak.uname | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config.mak.uname b/config.mak.uname > index 7b36a1dfe7..786bb2f913 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S))) > RC = windres -O coff > NATIVE_CRLF = YesPlease > X = .exe > - SPARSE_FLAGS = -Wno-one-bit-signed-bitfield > ifneq (,$(wildcard ../THIS_IS_MSYSGIT)) > htmldir = doc/git/html/ > prefix = > -- > 2.20.0 > ```