threads / patch / 5029

patchMakefile: ssh-pull.o depends on ssh-fetch.c

Subject: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c

## tl;dr

3 messages between Jul 28, 2006 and Jul 28, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin· Jul 28, 2006, 09:17 UTC · lore

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to Makefile +1 −0

diff --git a/Makefile b/Makefile
index 636679f..e8037ad 100644
--- a/Makefile
+++ b/Makefile
@@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)
 	$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
 		$(LIB_FILE) $(SIMPLE_LIB)
 
+ssh-pull.o: ssh-fetch.c
 git-local-fetch$X: fetch.o
 git-ssh-fetch$X: rsh.o fetch.o
 git-ssh-upload$X: rsh.o

-- 
1.4.2.rc2.g51ee8-dirty

Junio C Hamano· Jul 28, 2006, 18:14 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 17 quoted lines

> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 636679f..e8037ad 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)
>  	$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
>  		$(LIB_FILE) $(SIMPLE_LIB)
>  
> +ssh-pull.o: ssh-fetch.c
>  git-local-fetch$X: fetch.o
>  git-ssh-fetch$X: rsh.o fetch.o
>  git-ssh-upload$X: rsh.o

My personal preference would be to deprecate these commit walkers ;-) but in any case we would also need to make ssh-push.o depend on ssh-upload.c for the same logic.

Johannes Schindelin· Jul 28, 2006, 18:55 UTC · re: Junio C Hamano · lore

Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c

Hi,

On Fri, 28 Jul 2006, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > +ssh-pull.o: ssh-fetch.c
> 
> My personal preference would be to deprecate these commit walkers ;-) 
> but in any case we would also need to make ssh-push.o depend on 
> ssh-upload.c for the same logic.

Probably. But this was a _necessary_ fix: git stopped compiling here (yes, I could have done "make clean && make", but that takes all the fun out of it...).

Ciao, Dscho