{"thread":{"id":"5029","subject":"[PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c","startedAt":"2006-07-28T09:17:46Z","lastAt":"2006-07-28T18:55:22Z","messageCount":3,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24293","messageId":"Pine.LNX.4.63.0607281117240.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"5029","inReplyTo":null,"subject":"[PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-28T09:17:46Z","receivedAt":"2006-07-28T09:17:46Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n---\n Makefile |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 636679f..e8037ad 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)\n \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIB_FILE) $(SIMPLE_LIB)\n \n+ssh-pull.o: ssh-fetch.c\n git-local-fetch$X: fetch.o\n git-ssh-fetch$X: rsh.o fetch.o\n git-ssh-upload$X: rsh.o\n-- \n1.4.2.rc2.g51ee8-dirty\n"},{"id":"24313","messageId":"7vslkllhqo.fsf@assigned-by-dhcp.cox.net","threadId":"5029","inReplyTo":"Pine.LNX.4.63.0607281117240.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-07-28T18:14:07Z","receivedAt":"2006-07-28T18:14:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n> ---\n>  Makefile |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 636679f..e8037ad 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)\n>  \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n>  \t\t$(LIB_FILE) $(SIMPLE_LIB)\n>  \n> +ssh-pull.o: ssh-fetch.c\n>  git-local-fetch$X: fetch.o\n>  git-ssh-fetch$X: rsh.o fetch.o\n>  git-ssh-upload$X: rsh.o\n\nMy personal preference would be to deprecate these commit\nwalkers ;-) but in any case we would also need to make\nssh-push.o depend on ssh-upload.c for the same logic.\n"},{"id":"24315","messageId":"Pine.LNX.4.63.0607282054190.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"5029","inReplyTo":"7vslkllhqo.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-28T18:55:22Z","receivedAt":"2006-07-28T18:55:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 28 Jul 2006, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> > +ssh-pull.o: ssh-fetch.c\n> \n> My personal preference would be to deprecate these commit walkers ;-) \n> but in any case we would also need to make ssh-push.o depend on \n> ssh-upload.c for the same logic.\n\nProbably. But this was a _necessary_ fix: git stopped compiling here (yes, \nI could have done \"make clean && make\", but that takes all the fun out of \nit...).\n\nCiao,\nDscho\n"}]}