threads / patch / 49975

patchdocs/gitweb.conf: config variable typo

Subject: [PATCH] docs/gitweb.conf: config variable typo

## tl;dr

3 messages between Dec 8, 2018 and Dec 8, 2018. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Frank Dana· Dec 8, 2018, 00:26 UTC · lore

The documentation for the feature 'snapshot' claimed "This feature can be configured on a per-repository basis via repository's `gitweb.blame` configuration variable"

Fixed to specify `gitweb.snapshot` as the variable name.
---
 Documentation/gitweb.conf.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/gitweb.conf.txt +1 −2

diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
index c0a326e3883c3..40c9563ef67af 100644
--- a/Documentation/gitweb.conf.txt
+++ b/Documentation/gitweb.conf.txt
@@ -684,7 +684,7 @@ compressed tar archive) and "zip"; please consult gitweb sources for
 a definitive list.  By default only "tgz" is offered.
 +
 This feature can be configured on a per-repository basis via
-repository's `gitweb.blame` configuration variable, which contains
+repository's `gitweb.snapshot` configuration variable, which contains
 a comma separated list of formats or "none" to disable snapshots.
 Unknown values are ignored.
 

--
https://github.com/git/git/pull/562

Jonathan Nieder· Dec 8, 2018, 00:45 UTC · re: Frank Dana · lore

Re: [PATCH] docs/gitweb.conf: config variable typo

Hi,

Frank Dana wrote:

Show 8 quoted lines

> The documentation for the feature 'snapshot' claimed
> "This feature can be configured on a per-repository basis via
> repository's `gitweb.blame` configuration variable"
>
> Fixed to specify `gitweb.snapshot` as the variable name.
> ---
>  Documentation/gitweb.conf.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fixing it. May we forge your sign-off? See Documentation/SubmittingPatches section "Certify your work" for what this means.

Sincerely, Jonathan

FeRD· Dec 8, 2018, 00:48 UTC · re: Jonathan Nieder · lore

Re: [PATCH] docs/gitweb.conf: config variable typo

On Fri, Dec 7, 2018 at 7:45 PM Jonathan Nieder <jrnieder@gmail.com> wrote:

>
>
> Thanks for fixing it.  May we forge your sign-off?

Yes please, guess I didn't read far enough down that document. My apologies. Consider the previous patch email:

Signed-off-by: FeRD (Frank Dana) <ferdnyc@gmail.com>