# [PATCH] docs/gitweb.conf: config variable typo 3 messages from 2018-12-08 to 2018-12-08. Participants: Frank Dana, Jonathan Nieder, FeRD. Thread: https://gitlist.dev/t/49975 ## Frank Dana, 2018-12-08 00:26 Subject: [PATCH] docs/gitweb.conf: config variable typo Message-ID: <010201678b350faa-868bbac4-9242-427a-9d3b-fc6f00a95270-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/010201678b350faa-868bbac4-9242-427a-9d3b-fc6f00a95270-000000%40eu-west-1.amazonses.com ``` The documentation for the feature 'snapshot' claimed "This feature can be configured on a per-repository basis via repository's `gitweb.blame` configuration variable" Fixed to specify `gitweb.snapshot` as the variable name. --- Documentation/gitweb.conf.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt index c0a326e3883c3..40c9563ef67af 100644 --- a/Documentation/gitweb.conf.txt +++ b/Documentation/gitweb.conf.txt @@ -684,7 +684,7 @@ compressed tar archive) and "zip"; please consult gitweb sources for a definitive list. By default only "tgz" is offered. + This feature can be configured on a per-repository basis via -repository's `gitweb.blame` configuration variable, which contains +repository's `gitweb.snapshot` configuration variable, which contains a comma separated list of formats or "none" to disable snapshots. Unknown values are ignored. -- https://github.com/git/git/pull/562 ``` ## Jonathan Nieder, 2018-12-08 00:45 Subject: Re: [PATCH] docs/gitweb.conf: config variable typo Message-ID: <20181208004504.GG73340@google.com> URL: https://gitlist.dev/e/20181208004504.GG73340%40google.com In-Reply-To: <010201678b350faa-868bbac4-9242-427a-9d3b-fc6f00a95270-000000@eu-west-1.amazonses.com> ``` Hi, Frank Dana wrote: > The documentation for the feature 'snapshot' claimed > "This feature can be configured on a per-repository basis via > repository's `gitweb.blame` configuration variable" > > Fixed to specify `gitweb.snapshot` as the variable name. > --- > Documentation/gitweb.conf.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for fixing it. May we forge your sign-off? See Documentation/SubmittingPatches section "Certify your work" for what this means. Sincerely, Jonathan ``` ## FeRD, 2018-12-08 00:48 Subject: Re: [PATCH] docs/gitweb.conf: config variable typo Message-ID: URL: https://gitlist.dev/e/CAN1OggV1Xx%2BLZcwun1CRHtgow7t_w7UWhDOFq3uaY4qM4JCdOQ%40mail.gmail.com In-Reply-To: <20181208004504.GG73340@google.com> ``` On Fri, Dec 7, 2018 at 7:45 PM Jonathan Nieder wrote: > > > Thanks for fixing it. May we forge your sign-off? Yes please, guess I didn't read far enough down that document. My apologies. Consider the previous patch email: Signed-off-by: FeRD (Frank Dana) ```