threads / patch / 49692

patch, 3 partssome more hdr-check clean headers

Subject: [PATCH 0/3] some more hdr-check clean headers

## tl;dr

2 messages between Oct 27, 2018 and Oct 28, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Oct 27, 2018, 01:47 UTC · lore

I have some changes to the hdr-check Makefile target in the works, but these clean-ups don't have to be held up by those changes.

The 'fetch-object.h' patch is the same one I sent separately last time, since it only applied on 'next' at the time. The 'ewok_rlw.h' patch is just something I noticed while messing around the the Makefile changes. The 'commit-reach.h' patch is the patch #9 from the original series, but now with a commit message that explains the '#include "commit.h"' issue.

These changes are on top of current master (@c670b1f876) and merge without conflict to 'next' and with a 'minor' conflict on 'pu'.

Ramsay Jones (3):
  fetch-object.h: add missing declaration (hdr-check)
  ewok_rlw.h: add missing 'inline' to function definition
  commit-reach.h: add missing declarations (hdr-check)

 commit-reach.h  | 5 +++--
 ewah/ewok_rlw.h | 2 +-
 fetch-object.h  | 2 ++
 3 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.19.0

brian m. carlson· Oct 28, 2018, 15:40 UTC · re: Ramsay Jones · lore

Re: [PATCH 0/3] some more hdr-check clean headers

On Sat, Oct 27, 2018 at 02:47:47AM +0100, Ramsay Jones wrote:

Show 12 quoted lines

> 
> I have some changes to the hdr-check Makefile target in the works, but
> these clean-ups don't have to be held up by those changes.
> 
> The 'fetch-object.h' patch is the same one I sent separately last time,
> since it only applied on 'next' at the time. The 'ewok_rlw.h' patch is
> just something I noticed while messing around the the Makefile changes.
> The 'commit-reach.h' patch is the patch #9 from the original series, but
> now with a commit message that explains the '#include "commit.h"' issue.
> 
> These changes are on top of current master (@c670b1f876) and merge
> without conflict to 'next' and with a 'minor' conflict on 'pu'.

All three of these patches look sane to me.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204