# [PATCH 0/3] some more hdr-check clean headers 2 messages from 2018-10-27 to 2018-10-28. Participants: Ramsay Jones, brian m. carlson. Thread: https://gitlist.dev/t/49692 ## Ramsay Jones, 2018-10-27 01:47 Subject: [PATCH 0/3] some more hdr-check clean headers Message-ID: URL: https://gitlist.dev/e/ecb3d551-314a-aeef-048f-c1bbe0b3c999%40ramsayjones.plus.com ``` I have some changes to the hdr-check Makefile target in the works, but these clean-ups don't have to be held up by those changes. The 'fetch-object.h' patch is the same one I sent separately last time, since it only applied on 'next' at the time. The 'ewok_rlw.h' patch is just something I noticed while messing around the the Makefile changes. The 'commit-reach.h' patch is the patch #9 from the original series, but now with a commit message that explains the '#include "commit.h"' issue. These changes are on top of current master (@c670b1f876) and merge without conflict to 'next' and with a 'minor' conflict on 'pu'. Ramsay Jones (3): fetch-object.h: add missing declaration (hdr-check) ewok_rlw.h: add missing 'inline' to function definition commit-reach.h: add missing declarations (hdr-check) commit-reach.h | 5 +++-- ewah/ewok_rlw.h | 2 +- fetch-object.h | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) -- 2.19.0 ``` ## brian m. carlson, 2018-10-28 15:40 Subject: Re: [PATCH 0/3] some more hdr-check clean headers Message-ID: <20181028154052.GH6119@genre.crustytoothpaste.net> URL: https://gitlist.dev/e/20181028154052.GH6119%40genre.crustytoothpaste.net In-Reply-To: ``` On Sat, Oct 27, 2018 at 02:47:47AM +0100, Ramsay Jones wrote: > > I have some changes to the hdr-check Makefile target in the works, but > these clean-ups don't have to be held up by those changes. > > The 'fetch-object.h' patch is the same one I sent separately last time, > since it only applied on 'next' at the time. The 'ewok_rlw.h' patch is > just something I noticed while messing around the the Makefile changes. > The 'commit-reach.h' patch is the patch #9 from the original series, but > now with a commit message that explains the '#include "commit.h"' issue. > > These changes are on top of current master (@c670b1f876) and merge > without conflict to 'next' and with a 'minor' conflict on 'pu'. All three of these patches look sane to me. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 ```