threads / patch / 49070

patch, 2 partsFix two grammar errors related to the word "save"

Subject: [PATCH 0/2] Fix two grammar errors related to the word "save"

## tl;dr

5 messages between Aug 8, 2018 and Aug 8, 2018. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Johannes Schindelin via GitGitGadget· Aug 8, 2018, 11:49 UTC · lore

I stumbled over the one in git-compat-util.h while working on an unrelated bug fix, and then got curious whether there are other places where we use save instead of safe, too. Turns out we do not, but there was another grammar error where a spurious . interrupted a sentence.

Johannes Schindelin (2):
  git-compat-util.h: fix typo
  remote-curl: remove spurious period

 git-compat-util.h | 2 +-
 remote-curl.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

base-commit: 1d89318c48d233d52f1db230cf622935ac3c69fa
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-16%2Fdscho%2Fsave-typos-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-16/dscho/save-typos-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/16

-- 
gitgitgadget

Johannes Schindelin via GitGitGadget· Aug 8, 2018, 11:49 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH 1/2] git-compat-util.h: fix typo

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The words "save" and "safe" are both very wonderful words, each with their own set of meanings. Let's not confuse them with one another save on occasion of a pun.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-compat-util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to git-compat-util.h +1 −1

diff --git a/git-compat-util.h b/git-compat-util.h
index 9a64998b2..a9dfa0be0 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -220,7 +220,7 @@
 #endif
 #ifdef NO_INTPTR_T
 /*
- * On I16LP32, ILP32 and LP64 "long" is the save bet, however
+ * On I16LP32, ILP32 and LP64 "long" is the safe bet, however
  * on LLP86, IL33LLP64 and P64 it needs to be "long long",
  * while on IP16 and IP16L32 it is "int" (resp. "short")
  * Size needs to match (or exceed) 'sizeof(void *)'.

-- 
gitgitgadget

Johannes Schindelin via GitGitGadget· Aug 8, 2018, 11:50 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH 2/2] remote-curl: remove spurious period

From: Johannes Schindelin <johannes.schindelin@gmx.de>

We should not interrupt. sentences in the middle.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 remote-curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to remote-curl.c +1 −1

diff --git a/remote-curl.c b/remote-curl.c
index 99b0bedc6..fb28309e8 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -714,7 +714,7 @@ retry:
 
 	} else if (use_gzip && 1024 < rpc->len) {
 		/* The client backend isn't giving us compressed data so
-		 * we can try to deflate it ourselves, this may save on.
+		 * we can try to deflate it ourselves, this may save on
 		 * the transfer time.
 		 */
 		git_zstream stream;

-- 
gitgitgadget

Elijah Newren· Aug 8, 2018, 16:39 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH 2/2] remote-curl: remove spurious period

On Wed, Aug 8, 2018 at 4:52 AM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:

>
> We should not interrupt. sentences in the middle.

I love this. commit message.  :-)

...

>                 /* The client backend isn't giving us compressed data so
> -                * we can try to deflate it ourselves, this may save on.
> +                * we can try to deflate it ourselves, this may save on
>                  * the transfer time.

Junio C Hamano· Aug 8, 2018, 16:06 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH 0/2] Fix two grammar errors related to the word "save"

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines

> I stumbled over the one in git-compat-util.h while working on an unrelated
> bug fix, and then got curious whether there are other places where we use 
> save instead of safe, too. Turns out we do not, but there was another
> grammar error where a spurious . interrupted a sentence.
>
> Johannes Schindelin (2):
>   git-compat-util.h: fix typo
>   remote-curl: remove spurious period
>
>  git-compat-util.h | 2 +-
>  remote-curl.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Fix for typos made in 2009 and 2012, better late than never ;-)

Will queue.