{"thread":{"id":"49070","subject":"[PATCH 0/2] Fix two grammar errors related to the word \"save\"","startedAt":"2018-08-08T11:50:00Z","lastAt":"2018-08-08T16:39:14Z","messageCount":5,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"354796","messageId":"pull.16.git.gitgitgadget@gmail.com","threadId":"49070","inReplyTo":null,"subject":"[PATCH 0/2] Fix two grammar errors related to the word \"save\"","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-08-08T11:49:57Z","receivedAt":"2018-08-08T11:50:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"I stumbled over the one in git-compat-util.h while working on an unrelated\nbug fix, and then got curious whether there are other places where we use \nsave instead of safe, too. Turns out we do not, but there was another\ngrammar error where a spurious . interrupted a sentence.\n\nJohannes Schindelin (2):\n git-compat-util.h: fix typo\n remote-curl: remove spurious period\n\n git-compat-util.h | 2 +-\n remote-curl.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 1d89318c48d233d52f1db230cf622935ac3c69fa\nPublished-As: https://github.com/gitgitgadget/git/releases/tags/pr-16%2Fdscho%2Fsave-typos-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-16/dscho/save-typos-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/16\n-- \ngitgitgadget\n"},{"id":"354797","messageId":"e0e7b6ae9da313637fcbd79a31e4b628b1ddb798.1533728995.git.gitgitgadget@gmail.com","threadId":"49070","inReplyTo":"pull.16.git.gitgitgadget@gmail.com","subject":"[PATCH 1/2] git-compat-util.h: fix typo","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-08-08T11:49:58Z","receivedAt":"2018-08-08T11:50:02Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe words \"save\" and \"safe\" are both very wonderful words, each with\ntheir own set of meanings. Let's not confuse them with one another save\non occasion of a pun.\n\nSigned-off-by: Johannes Schindelin \n---\n git-compat-util.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 9a64998b2..a9dfa0be0 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -220,7 +220,7 @@\n #endif\n #ifdef NO_INTPTR_T\n /*\n- * On I16LP32, ILP32 and LP64 \"long\" is the save bet, however\n+ * On I16LP32, ILP32 and LP64 \"long\" is the safe bet, however\n * on LLP86, IL33LLP64 and P64 it needs to be \"long long\",\n * while on IP16 and IP16L32 it is \"int\" (resp. \"short\")\n * Size needs to match (or exceed) 'sizeof(void *)'.\n-- \ngitgitgadget\n\n"},{"id":"354798","messageId":"d9fa5b855ba2805d5afced4795c7d6e87f7e41b7.1533728995.git.gitgitgadget@gmail.com","threadId":"49070","inReplyTo":"pull.16.git.gitgitgadget@gmail.com","subject":"[PATCH 2/2] remote-curl: remove spurious period","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2018-08-08T11:50:00Z","receivedAt":"2018-08-08T11:50:05Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nWe should not interrupt. sentences in the middle.\n\nSigned-off-by: Johannes Schindelin \n---\n remote-curl.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/remote-curl.c b/remote-curl.c\nindex 99b0bedc6..fb28309e8 100644\n--- a/remote-curl.c\n+++ b/remote-curl.c\n@@ -714,7 +714,7 @@ retry:\n \n \t} else if (use_gzip && 1024 < rpc->len) {\n \t\t/* The client backend isn't giving us compressed data so\n-\t\t * we can try to deflate it ourselves, this may save on.\n+\t\t * we can try to deflate it ourselves, this may save on\n \t\t * the transfer time.\n \t\t */\n \t\tgit_zstream stream;\n-- \ngitgitgadget\n"},{"id":"354859","messageId":"xmqqmutwj10u.fsf@gitster-ct.c.googlers.com","threadId":"49070","inReplyTo":"pull.16.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/2] Fix two grammar errors related to the word \"save\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-08-08T16:06:41Z","receivedAt":"2018-08-08T16:06:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> I stumbled over the one in git-compat-util.h while working on an unrelated\n> bug fix, and then got curious whether there are other places where we use \n> save instead of safe, too. Turns out we do not, but there was another\n> grammar error where a spurious . interrupted a sentence.\n>\n> Johannes Schindelin (2):\n> git-compat-util.h: fix typo\n> remote-curl: remove spurious period\n>\n> git-compat-util.h | 2 +-\n> remote-curl.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n\nFix for typos made in 2009 and 2012, better late than never ;-)\n\nWill queue.\n"},{"id":"354870","messageId":"CABPp-BGnGeJ-9y5gM-_E90hUJPQvJTngy4DhPZ=6ZaCb+RMtpg@mail.gmail.com","threadId":"49070","inReplyTo":"d9fa5b855ba2805d5afced4795c7d6e87f7e41b7.1533728995.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] remote-curl: remove spurious period","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2018-08-08T16:39:00Z","receivedAt":"2018-08-08T16:39:14Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Wed, Aug 8, 2018 at 4:52 AM Johannes Schindelin via GitGitGadget\n wrote:\n>\n> We should not interrupt. sentences in the middle.\n\nI love this. commit message. :-)\n\n...\n> /* The client backend isn't giving us compressed data so\n> - * we can try to deflate it ourselves, this may save on.\n> + * we can try to deflate it ourselves, this may save on\n> * the transfer time.\n"}]}